search

denschub / firefox-tabgroups

[UNMAINTAINED] A Firefox addon that provides tab grouping features similar to the removed TabView/TabGroups/Panorama features.
Other
147 stars 28 forks source link

#9 Add confirmation when closing a group #34

Closed xiio closed 7 years ago

xiio commented 8 years ago

i've added confirmation prompt on group closing. When group is empty there is no need to confirm.

xiio commented 8 years ago

I've fixed code according to your notes.

denschub commented 8 years ago

Okay, I've tested it. It... works, but the dialog box is somehwat annoying to me since I usually have a lot of temporary groups. I'd suggest adding a preference to turn off the question.

Preferences can be added in package.json and you can use Prefs.prefs.[name] in index.js to get their value. Please add the title of your preference to en-US.properties, although you'll have to repeat the same string twice. This is to make translating the stuff a bit easier. Use [name]_title (and [name]_description if you want to add a longer description) as the key in the upper block of the language file and the SDK will do its magic.

After that, let's squash your commits into a single one. In larger PRs, multimple commits may be okay but commits lke "added missing .length" just bloat up the git history. To squash, use git rebase -i develop and replace every pick but the first through squash. Git will then ask you for a new commit message and I'd suggest to use something like Add confirmation when closing a group. After that, you have to force-push your branch, but that's okay!

xiio commented 8 years ago

how can i add new icon? i mean "undo" icon. I see it is Font Awesome, but it is customized set...

denschub commented 8 years ago

I've added the undo-icon in bebc29123bcc00dd61da5cdcd49ba643f6659381. Rebase and you can use .fa-undo

xiio commented 8 years ago

I've changed the form of this confirmation. Now it doesn't need so much interacition from user. I've added new pref for this feature so it is configurable. Check this out.

xiio commented 8 years ago

Is there any problem?

denschub commented 8 years ago

Sorry, I've been busy with stuff. I just added some remarks! Thanks for your work so far.

denschub commented 8 years ago

@xiio any chance you'll finish this?

xiio commented 8 years ago

Sorry, I've been busy lately. I will fix it till Tuesday (31.05)

denschub commented 8 years ago

Awesome! 😸

Don't hurry, just wanted to know whether I should take this over myself or not. :)

xiio commented 8 years ago

I've made fixes according to your suggestions.

denschub commented 8 years ago

Thanks, we're getting close! 👍 Sorry for being kinda picky, but I'd rather stick with a clean and nice code base or we might create a monster that nobody will ever be able to support.

xiio commented 8 years ago

All done. Please review...

denschub commented 7 years ago

Sorry for the insane delay, I got totally sidetracked. Merged as 3a869eb74939f1ee6637b5bf10b8b4caf3dd9e5c now, thank you!