denschub / firefox-tabgroups

[UNMAINTAINED] A Firefox addon that provides tab grouping features similar to the removed TabView/TabGroups/Panorama features.
Other
147 stars 28 forks source link

Port to WebExtension #60

Open yodaldevoid opened 7 years ago

yodaldevoid commented 7 years ago

With the "old" plugin formats for Firefox getting support dropped not terribly long into the future, will this plugin survive? The other big tab groups plugin has had it's developer decide to stop supporting it as the amount of work to port it to WebExtensions is too great for what he gets out of it. Will development support for this also be stopped, or will it be ported to WebExtensions? No matter how this pans out, thank you for all the work on this plugin.

denschub commented 7 years ago

will this plugin survive

yes.

yodaldevoid commented 7 years ago

Sorry for the melodrama, it may have been a little too late (early?) when I submitted this.

Beyond that, I would love to help port this or do any other work to make that easier. I'm not a plugin developer by any means, so if there are sub-tasks to porting the plugin please feel free to list them as I would not know what they are otherwise.

teranex commented 7 years ago

I'm currently using Tab Groups, but this will not receive updates anymore, so I'd like to give this extension a try. If I install this extension, will it use all the tabs and tabgroups I currently have in Tab Groups? And will I be able to switch back from this extension to tab groups, should I feel the need?

yodaldevoid commented 7 years ago

The tab groups transfer between the two addons without needing to do anything. For questions like this in the future please create a new issue.

ScottRFrost commented 7 years ago

I noticed that there is no Project or Milestone set for this issue. Any idea if porting to web extension will happen before Firefox 57 hits beta on 2017-09-26, when this addon will cease to function??

machineloop commented 7 years ago

Thanks @denschub for your work on this add-on over the years, I've really enjoyed using it. Nightly (57.0a1 2017-08-11) just disabled legacy add-ons 6 weeks ahead of release of 57. I re-enabled legacy add-ons, but looks like the button doesn't show up anymore to access tabgroups. Anything I can do to help? I've done a bit of work with Firefox add-ons in the past, but nothing with the new WebExtension APIs, but would be happy to pitch in.

denschub commented 7 years ago

Read this bug and the comments on that. I will start working on this as soon as the API landed, just as I promised. Right now, there is nothing I can do and there is nothing I will do, since I'd rather have something clean than a a hack that I need to update every 2 days to have it working.

A lot of stuff will change in Nightly over the next few weeks, and I will be busy with work, so I'm not going to maintain a hack. I will, however, port the extension as soon as I have the APIs I need.

scheinercc commented 7 years ago

@machineloop have you found a way to access those tabs?

denschub commented 7 years ago

To restore hidden tabs:

  1. Open the DevTools (F12), open the DevTools settings (the gear icon in the top right corner of the Devtools), enable Enable browser chrome and add-on debugging toolboxes.
  2. Open the Browser console (Tools -> Web Developer -> Browser console).
  3. Paste gBrowser.showOnlyTheseTabs(Array.from(gBrowser.tabs)) into the input area and hit enter.
denschub commented 7 years ago

please discuss in the appropriate areas.

Please don't duplicate information. If people are interested in the Firefox development side, they can follow 1384515. All new issues are linked in there. If people decide not to follow the issue on bugzilla, than that's because they are not interested in the development history and only want to know when my extension is ported.

rubcap commented 7 years ago

Thanks @denschub for your continued work on this add-on! I understand this won't make it to Firefox 57 due to a missing WE-API, but I really look forward to a WE compatible version! đź‘Ť

nkkollaw commented 7 years ago

I'm having somewhat of a hard time figuring out the status of this. Is this extension getting ported to WE?

I suck and wouldn't know where to start with helping, but I do enjoy, love, and need this extension and would hate to see it die.

denschub commented 7 years ago

Is this extension getting ported to WE?

Oh please... ;)

screen shot 2017-11-10 at 02 27 44

As mentioned before: I will update this issue as soon there is something to update.

denschub commented 6 years ago

So, before I get another 91 emails (yes, I'm serious) to inform me that tabHide support has landed: I know. Hope to find the time to spend some time coding here soon, and I will update this thread as usual.

denschub commented 6 years ago

Alright people. It's more than a year since this issue has been created, and I think I owe you all a reply.

Back in April last year, I assumed that landing required WebExtension APIs should be done very soon, and made time for that in my schedule. As everyone who followed the Bugzilla thread is aware, implementing a tabHide API actually was much more complicated than anticipated, and thus got delayed by quite a bit.

While I had the time and motivation to port this extension to WebExtension last year, I've since moved on. I depend on using Firefox Nightly on a daily basis, so I was unable to use tab groups for quite some time now, and today, I don't really have the need for it anymore. And as I don't need it for myself anymore, I cannot really justify the time investment to port it these days. There is just too much stuff going on in my life, y'all know how it is.

So, long story short: I'll put this repository in an "officially unmaintained" state, as I won't be able to put the effort in anytime soon.

That being said, if anyone wants to step forward and do the port, feel free to do so. I am very happy to mentor an implementation and answer every questions, feel free to reach out to me in that case. If there is a working port, I'm more than happy to transfer this repo and also the AMO listing to the new maintainer.

Harsh decision I have to make, but I'm sure most of you understand. Thanks for the support!

hadrianw commented 6 years ago

I would only like to point people to alternatives. I currently use Totally not Panorama which itself is a fork of Panorama View. They are almost a complete copy of the original Tab Groups feature. So they're not Simplified, but more Full Tab Groups.

Totally not Panorama works great for me - it supports tab hiding.

Wobbler44 commented 6 years ago

Not familiar with 'Totally not Panorama', but I recently started using 'Sync Tab Groups' by Morikko which works nicely and was finally able to do the long outstanding Firefox update and abandon this legacy 'Simplified Tab Groups' - thanks Dennis for your past work.

grahamperrin commented 6 years ago

@denschub thanks for the frank explanation đź‘Ť

… implementing a tabHide API …

Shortly before your comment, I began searching Bugzilla for anything relating to a groups API. Can't find one … am I missing something? https://discourse.mozilla.org/t/-/28533?u=grahamperrin if you'd like to reply there. TIA


All: https://github.com/Quicksaver/Tab-Groups/issues/535 seems to be a favoured meeting place for developers, testers and users of possible alternatives to Tab Groups. Maybe use the same issue 535 for discussion of possible alternatives to Simplified Tab Groups (prefer to track the mixture in one place, not two or more). Cheers.

denschub commented 6 years ago

@grahamperrin you don't need a "groups" API, and even pre-quantum, there was none. You have to keep track of the tabs yourself and hide/show them when needed.

bz007 commented 6 years ago

@hadrianw thanks a lot for TnP! It is exactly what I wanted!

psxlover commented 6 years ago

Can anyone who has tried the latest versions of Panorama View and Totally not Panorama post a comparison? Thanks

hadrianw commented 6 years ago

@psxlover: from Totally not Panorama extension's description:

Enhancements, compared to Panorama View 0.6.15 by photodiode:

  • Support for hiding tabs (Firefox 59+)
  • On-demand screenshots (Firefox 59+)
  • Support pinned tabs
  • Ctrl+E opens/closes the panorama view (Ctrl+Shift+E for Mac)
  • The keyboard shortcut is configurable for Firefox 60 users. You can only set shortcuts which are not otherwise used by the browser.
  • Dragging a tab out of a group creates a new group with this tab in it
  • Resize and move groups
  • Create a new group by drawing in the empty space in the panorama view

Limitations (compared to Tab Groups by Quicksaver):

  • Doesn't work in Private Browsing windows
  • No "Undo closed group" button
  • No automatic group management - you need to assign tabs to groups manually
  • No context menu actions
  • Groups may overlap, you need to select appropriate sizes manually
psxlover commented 6 years ago

I saw that, but that is referring to version 0.6.15 of Panorama View which is old. From what I understand Panorama View does support hiding of tabs, and has had several updates since the last version of Totally not Panorama was released.

Termuellinator commented 6 years ago

@psxlover , i just tried TnP now, have used PV for a while - for now, i like TnP better because the handling of pinned tabs suits me better and it feels a tad smoother when changing groups. All in all they are both very similar and great addons and a good replacement for tab groups :)

psxlover commented 6 years ago

the handling of pinned tabs suits me better How are they handled in each addon? Which one is the same as the old tab groups (pinned tabs stay visible on all groups), because I use pinned tabs for e-mail and I want them always visible.

emyarod commented 6 years ago

@psxlover @hadrianw for what it's worth: the developer of Totally not Panorama now contributes to Panorama View

Termuellinator commented 6 years ago

@psxlover in PV they are viewn as part of a group, but when you click them while in another group they will appear on their own - kinda weird in my opinion. in TnP they are viewn seperately on the right and appear in the tab-bar of every group. @emyarod interesting - we'll have to wait and see how things go further O_o

psxlover commented 6 years ago

@Termuellinator I just tried Panorama View, and even though the pinned tabs appear as part of group, they work correctly when in another group (they show while having selected another group, and they don't switch the tab group when selected)

ScottRFrost commented 6 years ago

Conex is the closest I've found to a replacement. It's not as slick as TabGroups was, but it does have the additional functionality of integrating with Firefox Multi-Account Containers (so sessions / cookies / etc stay in the "group" and can't be seen in other groups).

It works pretty well, but I'd love to see a true TabGroups for WebExtensions.

Keith94 commented 6 years ago

It works pretty well, but I'd love to see a true TabGroups for WebExtensions.

@ScottRFrost The closest you will get is Simple Tab Groups, the one I use personally. :-)

alex29ua commented 6 years ago

Anything that has the tabs panel for groups as well? So I don't have to click the button to see the groups like in "Sync Tab groups" etc. They all don't have screenshots, hard to choose...

pinta83 commented 6 years ago

@alex29ua Simple Tab groups from two reply's above.... You have simple groups, but you can click on the "Manage groups" to get almost identical grid view to old Tab Groups... Alltough if you name your groups right and setup colors to your needs - you won't have to go into grid/manage view

alex29ua commented 6 years ago

I don't need anything more complicated than a simple tabs row. Like I already have for usual pages, but for groups. This way I always see the groups and counts. They are like contexts/topics to me, easily switchable. Also easy to move tabs/pages around.

Possible in one of replacements? image

alreadydone commented 6 years ago

In the old TabGroups Manager you can drag one or multiple tabs to another tab group, a feature that seems to missing in nowadays tab group WEs. (Tab groups are listed horizontally and tabs can be listed vertically through add-ons.)

gaekwad commented 6 years ago

I tried TnP and it's pretty good. The only thing I don't like about it is there doesn't seem to be shortcut keys for switching to the next/previous group like there was in the old Tab Groups. I switched groups a lot, and now to do that I'd have to do Ctrl+E (or whatever I have it set to) and click on a tab every time.

rustymonkey commented 6 years ago

I've looked at all of the alternatives suggested above and all require the permission "Access your data for all websites". Can anyone who's developed these types of addons explain whether this is actually necessary for an implementation of a Tab Groups type of feature? I'm a bit apprehensive of giving a third-party addon this level of access. Thanks.

EDIT: it looks like Morriko's 'Sync Tab Groups' doesn't require this permission. Not sure why all the others do...

peci1 commented 6 years ago

@rustymonkey As I understand it, the creators of these addons usually require it for fetching favicons or page previews. If it's the only reason, it should be possible to create an addon that doesn't require this privilege, but the UI would be less user-friendly.

fturcheti commented 6 years ago

I have tested all the alternatives above and couldn't really stick to none. At the moment I'm using Tiled Tab Groups, by chzesa, and it fit my needs better.

shangles commented 6 years ago

Totally not Panorama works pretty good for me.

sacp commented 6 years ago

Totally not Panorama works pretty good for me.

That's also what I've been using for some weeks now

Vampire commented 6 years ago

I currently use Totally not Panorama which itself is a fork of Panorama View. They are almost a complete copy of the original Tab Groups feature. So they're not Simplified, but more Full Tab Groups.

Can someone say how those compare to this add-on? Was this more elaborate, or was this more simplified, or was it just different. It's so long that no tab groups worked, that I forgot why I used this one and not one of the others and what the features were exactly.

thePanz commented 6 years ago

I found TabPanorama hanging when loading lot of tabs (imported from TabGroups) Panorama does not support lazy loading of tabs It is quite hard to manage groups with panorama, the list-view of this Simple-TabGroups is way better IMHO

archerindigo commented 6 years ago

Tried Simple-TabGroups and Panorama View for some time.

Simple-TabGroups use the old list-view which is more comfortable but it reload all the tabs when switching group. That's not what I desired.

Panorama View is better to view all the tabs opened but it doesn't support tab-hiding and not so smart in ordering and grouping the tabs. It seems to be RAM hungry either as I noted the RAM usage raise quickly during the days using it.

Both are not the perfect replacement IMHO.

aullik commented 6 years ago

Panorama View has switched over to tab hiding a while ago. It allows orienting the tab-groups freely.

However it is RAM hungry and it has no export/import functionality yet.

Panorama View is more of a replacement to the old Quicksaver/Tab-Groups that died with FF57

Thanks @udovdh for correcting me. The import export function can be found under about:addons => Panorama View => Options

udovdh commented 6 years ago

Panorama view has export/import but with issues. RAM usage I did not quantify.

Vampire commented 6 years ago

Didn't this plugin also have the Ctrl+E view and not only a list view? I think I used this until the end (WebExtensions only).

udovdh commented 6 years ago

There is a panorama-type overview in Panorama view

Vampire commented 6 years ago

As is in TnP as far as I understood and as was in this add-on as far as I remember.

archerindigo commented 6 years ago

Panorama View has switched over to tab hiding a while ago. It allows orienting the tab-groups freely.

However it is RAM hungry and it has no export/import functionality yet.

Panorama View is more of a replacement to the old Quicksaver/Tab-Groups that died with FF57

Thanks @udovdh for correcting me. The import export function can be found under about:addons => Panorama View => Options

Alright I just forgot to enable tab hiding

thePanz commented 6 years ago

@archer1609 SimpleTagGroup implemented the lazy-loading of tabs. Tabs are displayed but not "running" until you activate them.