dense-analysis / ale

Check syntax in Vim/Neovim asynchronously and fix files, with Language Server Protocol (LSP) support
BSD 2-Clause "Simplified" License
13.54k stars 1.43k forks source link

Gometalinter command options leading to no output #1360

Closed al3xandru closed 6 years ago

al3xandru commented 6 years ago

Information

VIM version

NVIM v0.2.2 Build type: Release LuaJIT 2.0.5

Operating System: WHAT OS WERE YOU USING?

macOS 10.13.3

:ALEInfo

 Current Filetype: go
Available Linters: ['go build', 'gofmt', 'golint', 'gometalinter', 'gosimple', 'gotype', 'go vet', 'staticcheck']
  Enabled Linters: ['gometalinter']
 Linter Variables:

let g:ale_go_gometalinter_executable = 'gometalinter'
let g:ale_go_gometalinter_lint_package = 0
let g:ale_go_gometalinter_options = '--no-config --disable-all --aggregate --enable=errcheck --enable=golint --enable=gofmt --enable=vet --enable=goimports'
 Global Variables:

let g:ale_cache_executable_check_failures = 0
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = 250
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = 50
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_
clipboard: error: -2history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 500
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'never'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {'go': ['gometalinter'], 'python': ['pyflakes', 'pylint']}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = 10
let g:ale_loclist_msg_format = '%code: %%s'
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = 0
let g:ale_open_list = 'on_save'
let g:ale_pattern_options = {}
let g:ale_pattern_options_enabled = 0
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = 'E'
let g:ale_sign_info = 'I'
let g:ale_sign_offset = 1000000
let g:ale_sign_style_error = 'ES'
let g:ale_sign_style_warning = 'WS'
let g:ale_sign_warning = 'W'
let g:ale_statusline_format = ['%d error(s)', '%d warning(s)', 'OK']
let g:ale_type_map = {}
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
  Command History:

(executable check - success) gometalinter
(started) ['/bin/bash', '-c', 'cd ''/Users/alex/Dropbox/workspaces/mine/goland/gospace/src/github.com/al3xandru/basicwebsrv'' && ''gometalinter'' --include=''filewebserver_test\.go'' --no-config --disable-all --aggregate --enable=errcheck --enable=golint --enable=gofmt --enable=vet --enable=goimports .']
(finished - exit code 0) ['/bin/bash', '-c', 'cd ''/Users/alex/Dropbox/workspaces/mine/goland/gospace/src/github.com/al3xandru/basicwebsrv'' && ''gometalinter'' --include=''filewebserver_test\.go'' --no-config --disable-all --aggregate --enable=errcheck --enable=golint --enable=gofmt --enable=vet --enable=goimports .']

<<<NO OUTPUT RETURNED>>>

(finished - exit code 0) ['/bin/bash', '-c', 'cd ''/Users/alex/Dropbox/workspaces/mine/goland/gospace/src/github.com/al3xandru/basicwebsrv'' && ''gometalinter'' --include=''filewebserver_test\.go'' --no-config --disable-all --aggregate --enable=errcheck --enable=golint --enable=gofmt --enable=vet --enable=goimports .']

<<<NO OUTPUT RETURNED>>>

(finished - exit code 0) ['/bin/bash', '-c', 'cd ''/Users/alex/Dropbox/workspaces/mine/goland/gospace/src/github.com/al3xandru/basicwebsrv'' && ''gometalinter'' --include=''filewebserver_test\.go'' --no-config --disable-all --aggregate --enable=errcheck --enable=golint --enable=gofmt --enable=vet --enable=goimports .']

<<<NO OUTPUT RETURNED>>>

What went wrong

The command options used with gometalinter generate no output. But changing the command to pass the file name at the end results in the expected output:

> gometalinter --no-config --disable-all --aggregate --enable=errcheck --enable=golint --enable=gofmt --enable=vet --enable=goimports filewebserver_test.go

filewebserver_test.go:23:17:warning: error return value not checked (undeclared name: serveFiles) (errcheck)
filewebserver_test.go:50:17:warning: error return value not checked (undeclared name: serveFiles) (errcheck)

The main difference I can see is how the current file is passed to gometalinter

arp242 commented 6 years ago

Can you still reproduce this @al3xandru? Can you reproduce it with a minimal Vim configuration (loading only the ALE plugin)? What does your Go file look like?

A possible reason may be that the filewebserver_test.go is guarded by a build tag (e.g. // +build integrationtest)?

al3xandru commented 6 years ago

Unfortunately I don't have this setup available anymore to test.

w0rp commented 6 years ago

I'll close this until someone can provide steps for repeating the bug.