dense-analysis / ale

Check syntax in Vim/Neovim asynchronously and fix files, with Language Server Protocol (LSP) support
BSD 2-Clause "Simplified" License
13.55k stars 1.44k forks source link

Disable LanguageTool for Markdown #3379

Open oblitum opened 4 years ago

oblitum commented 4 years ago

LanguageTool is not proper for handling Markdown content. The presence of the tool in the command line will cause ALE by default to render Markdown files full of irrelevant warnings, simply because LanguageTool doesn't understand the syntax, it can only proofread plain text.

I don't use AsciiDoc, but it may be in the same boat, or worse.

I recommend that ALE changes this and leave LanguageTool for plain text files only.

To use LanguageTool for Markdown, it's best to employ a wrapper, as attempted at #3376 with TeXtidote.

hsanson commented 4 years ago

There is people that do use languagetool for Markdown and Asciidoc:

Rather that remove support for LanguateTool for asciidoc and markdown that seems to be useful for some I would recommend to g:ale_linters variable to disable it for these file types.

oblitum commented 4 years ago

Changed back title to disable. FWIW I think most of those user would be much more happy by using a proper wrapper instead, the LanguageTool experience on Markdown is simply bad.

hsanson commented 4 years ago

Add this to your configuration for the desired result:

let g:ale_linters_ignore = {
  \   'markdown': ['languagetool'],
  \   'asciidoc': ['languagetool']
  \}
oblitum commented 4 years ago

@hsanson it's not personal issue, I know that conf in particular already. The issue is about disabling it by default. As stated already, languagetool is not a tool for parsing Markdown, according to the authors themselves.

JensHeinrich commented 4 years ago

Yes, it is not but this could be considered a breaking change I think. My suggestion would be to disable languagetool as a direct linter, if the textidote wrapper is available to get the best of both worlds.

oblitum commented 4 years ago

@JensHeinrich could be a breaking change for those that consider it more useful than problematic, but also could be a relief for those that consider their markdown is being gratuitously filled with false positives. This was overlooked when added, it was a mistake (I was at the issue thread that added languagetool, and thought it was great).

karlb commented 6 months ago

So far I only got the "Possible typo: you repeated a whitespace" warning and am quite happy with the languagetool integration otherwise. Maybe we can ignore that rule for markdown by default?