search

dense-analysis / ale

Check syntax in Vim/Neovim asynchronously and fix files, with Language Server Protocol (LSP) support
BSD 2-Clause "Simplified" License
13.51k stars 1.43k forks source link

ale-info ftplugin doesn't set b:undo_ftplugin #4624

Closed benknoble closed 10 months ago

benknoble commented 12 months ago

https://github.com/dense-analysis/ale/blob/14350dbb0d265ef87d1c7d420d89fb4165a2b131/ftplugin/ale-info.vim#L1

It is crucial that ftplugin authors set b:undo_ftplugin to commands that revert the ftplugin. See the distributed runtime files for examples. My own script generates the following for this plugin:

let b:undo_ftplugin = get(b:, 'undo_ftplugin', 'execute') . ' | setlocal synmaxcol< | execute "silent! nunmap <buffer> q" | execute "silent! nunmap <buffer> <space>" | delfunction! ALEInfoOpenHelp'

I haven't looked at the other ftplugins, but I imagine they are missing similar items.

w0rp commented 12 months ago

Thanks for reporting this! I'll fix this eventually, if someone else doesn't fix it first.

benknoble commented 12 months ago

I'll add it to my todos. I'm hoping to have some time in a few hours to blitz through some open-source stuff on my list.