search

dense-analysis / ale

Check syntax in Vim/Neovim asynchronously and fix files, with Language Server Protocol (LSP) support
BSD 2-Clause "Simplified" License
13.38k stars 1.42k forks source link

embertemplatelint should run on gjs files as well (javascript.glimmer) #4652

Open SamSaffron opened 7 months ago

SamSaffron commented 7 months ago

Current embertemplatelint only runs on handlebars (.hbs) files.

This is incomplete as gjs files also need this linting. I tried a PR here, but am a bit lost... specifically:

  1. We only want to call this linter on javascript.glimmer, if I try to paste a copy/paste file into a javascript.glimmer directory in linters it does not run, only way I can get it to work is paste it into javascript
  2. I would like to reuse the handlebars implementation, not sure how to share this code
SamSaffron commented 7 months ago

Super hacky way of getting this to work

https://github.com/dense-analysis/ale/pull/4653

but code duplication is terrible