search

dense-analysis / ale

Check syntax in Vim/Neovim asynchronously and fix files, with Language Server Protocol (LSP) support
BSD 2-Clause "Simplified" License
13.57k stars 1.44k forks source link

ALE doesn't reply to the `workspace/applyEdit` request #4670

Open novadev94 opened 11 months ago

novadev94 commented 11 months ago

Information

VIM version

NVIM v0.9.4
Build type: Release

Operating System: macOS 14.1.1

What went wrong

ALE doesn't reply to the workspace/applyEdit request from the LSP server, which is required in the specification https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_applyEdit

Therefore, executing a code action would hang the LSP server, making it unable to handle other requests. Restarting the LSP server makes everything work again until a code action is executed.

Reproducing the bug

Use ALE with gopls and try executing any code actions. After that, nothing works (jump to definition, diagnostics,...).

novadev94 commented 11 months ago

A patch like this (https://github.com/novadev94/ale/commit/c5801b584cdb167784b418c91787d95d4565bb20) helps, but it's definitely not a long-term fix.