dense-analysis / ale

Check syntax in Vim/Neovim asynchronously and fix files, with Language Server Protocol (LSP) support
BSD 2-Clause "Simplified" License
13.38k stars 1.42k forks source link

fix(biome): send correct language to lsp proxy #4773

Closed redbmk closed 1 week ago

redbmk commented 1 month ago

Since Biome understands typescriptreact and javascriptreact as languages, we can send the filetype to the LSP, rather than only sending typescript for both ts and tsx files, or javascript for js and jsx files.

fixes: #4752


I moved the ale_typescript_biome.vader tests to just ale_biome.vader since it covers multiple languages, and I added some tests for this case. I also fixed what seemed like an issue with the biome tests where if the linters run first then the fixers fail. Now it saves the variables and resets them before the tests.

Linting and biome vader tests both pass locally for me