search

dense-analysis / ale

Check syntax in Vim/Neovim asynchronously and fix files, with Language Server Protocol (LSP) support
BSD 2-Clause "Simplified" License
13.51k stars 1.43k forks source link

Update xvlog.vim #4793

Open zht-coder opened 3 months ago

zht-coder commented 3 months ago

when using xvlog in Vivado 2019.1 for SystemVerilog, you should add the option '-sv'.

Where are the tests? Have you added tests? Have you updated the tests? Read the comment above and the documentation referenced in it first. Write tests!

Seriously, read :help ale-dev and write tests.

hsanson commented 3 months ago

Also there is a linter error:

ale_linters/verilog/xvlog.vim:6:14: Use robust operators ==# or ==? instead of == (see Google VimScript Style Guide (Matching))