search

denshoproject / ddr-cmdln

Command-line tools for automating the Densho Digital Repository's various processes.
Other
0 stars 2 forks source link

Certain attributes should be able to inherit their default value from a parent #104

Closed gjost closed 5 years ago

gjost commented 5 years ago

More attribute inheritance of default values for new files and/or entities in DDR Editor UI Set a default value based on parent collection, but do not link inheritance to parent collection. courtesy line, contributing institution, digitizer, digitizing institution

Update: The desired behavior is that when a new object is created, the default values for inheritable fields should be values from the parent object, not those from `ddr-defs.

gjost commented 5 years ago

I don't quite know what this feature is supposed to do. Could you describe it a bit more?

gjost commented 5 years ago

Can you please be more specific? There are no fields named "courtesy line" contributor AKA contributing institution is already inheritable. I made digitize_person and digitize_organization inheritable, but this only means that segments will inherit from entities - there is no related field in colleciton. Files have digitize_person but not digitize_organization.

GeoffFroh commented 5 years ago

Umm...that’s in the description of issue 241. Please read. https://github.com/densho/ddr-local/issues/241

On Oct 10, 2018, at 3:59 PM, geoffrey jost notifications@github.com wrote:

Can you please be more specific? There are no fields named "courtesy line" "contributor" AKA contributing institution is already inheritable. I made digitizer and digitizing institution inheritable, but this only means that segments will inherit from entities - there is no related field in colleciton.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

GeoffFroh commented 5 years ago

From original issue (https://github.com/densho/ddr-local/issues/241)

collection.contributor --> entity.contributor collection.prefercite --> entity.credit

gjost commented 5 years ago

collection.contributor --> entity.contributor collection.prefercite --> entity.credit

Already got those ones. I'm wondering what you'd like to do about "courtesy line" and the "digitizer*" fields. "Courtesy line" doesn't exist anywhere in defs. Collection has no "digitizer" fields. File has digitize_person but not digitize_organization.

GeoffFroh commented 5 years ago

prefercite/credit are the courtesy line

On Oct 11, 2018, at 2:36 PM, geoffrey jost notifications@github.com wrote:

collection.contributor --> entity.contributor collection.prefercite --> entity.credit Already got those ones. I'm wondering what you'd like to do about "courtesy line" and the "digitizer*" fields. "Courtesy line" doesn't exist anywhere in defs. Collection has no "digitizer" fields. File has digitize_person but not digitize_organization.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

GeoffFroh commented 5 years ago

file.digitize_person inherits from entity.digitize_person

gjost commented 5 years ago

Fixed as of commit 99f16aa.