denshoproject / ddr-cmdln

Command-line tools for automating the Densho Digital Repository's various processes.
Other
0 stars 2 forks source link

Template switching not working on AV entities #123

Closed sarabeckman closed 5 years ago

sarabeckman commented 5 years ago

When indexing ddr-csujad-29, ddr-csujad-30, and ddr-csujad-31 using ddrlocal-develop_2.6.8w I noticed the AV entities weren't displaying as we had discussed.

The 'download transcript' button wasn't on the page etc. Looking closer there is no template attribute https://ddrstage.densho.org/api/0.2/ddr-csujad-29-54/ (see ddr-csujad-28-1 for comparison https://ddrstage.densho.org/api/0.2/ddr-csujad-28-1/)

GeoffFroh commented 5 years ago

Sara tested indexing with ddr-csujad-29 and ddr-csujad-28. The indexer seemed to add the template attribute for ddr-csujad-28 (see link above), but did not for ddr-csujad-54.

Both entities are type = av, with a single mezzanine file with mimetype = audio/mpeg

see: ddr-csujad-28-1-mezzanine-93bba06d9c.json and ddr-csujad-29-54-mezzanine-66b5f55aaf.json

gjost commented 5 years ago

When indexing objects for publication, the template attribute is added in DDR.models.common line 395. This line is only executed if the object has a corresponding record at Internet Archive (see line 387).

With the current code, if records are not uploaded to IA then it is impossible for objects to have an A/V template.

GeoffFroh commented 5 years ago

Confirmed IA-dependent behavior. Will leave as is for now.