search

denshoproject / ddr-cmdln

Command-line tools for automating the Densho Digital Repository's various processes.
Other
0 stars 2 forks source link

binary display not functioning properly. #147

Closed pkikawa closed 5 years ago

pkikawa commented 5 years ago

2.8.3b DEV

webui tabs are showing correct number of binaries (mostly - see NOTE), but do not list them correctly (see bellow) binariesnotshowing1

binaries appear to be created correctly and added to the parents entity json (see examples in ddr-testing-40219-1 entity.json) ddr-testing-40219.zip

setting binary as object/collection signature works. binaries are accessible via webui (fullsize and access files downloading normally), but editing and saving the data results in this error: Exception at _ui_fileNone.txt with failure message :InvalidInputException("Could not grok Identifier input: {'url': None, 'path': None, 'parts': None, 'id': None, 'base_path': '/var/www/media/ddr'}",) the change is saved, but the change does NOT get staged for commit.

NOTE: adding a binary (for example a .pdf to Administrative) to a child entity causes the parent's Administrative tab to show that there is a binary present (see bellow) childentitiesShowingInParentTab in the above example i added a .pdf to ddr-testing-40219-1-2 Administrative. i had not added an Admin binary to ddr-testing-40219-1.

pkikawa commented 5 years ago

addon note - I am seeing this behavior in pre-existing collections olderColelctionBehaviro

gjost commented 5 years ago

This is an error in the function that reads the entity.json and packages the data for displaying this page. I believe fixed this exact thing but it looks like it didn't get into that package.

gjost commented 5 years ago

Should be fixed as of commit 85439e4dd5.