search

denshoproject / ddr-cmdln

Command-line tools for automating the Densho Digital Repository's various processes.
Other
0 stars 2 forks source link

ddr-signatures not writing to files when status == inprocess or public == 0 #151

Closed sarabeckman closed 5 years ago

sarabeckman commented 5 years ago

Ran ddr-signatures against ddr-densho-397 using my local VM running Master 2.8.4. It didn't write anything to the files.
ddr-signatures_output.txt

GeoffFroh commented 5 years ago

@sarabeckman reports that the functionality works when invoked from the webui (button on file detail page).

GeoffFroh commented 5 years ago

(This is not a critical bug for 2.8.4 master. Barring other issues, we can deploy 2.8.4 package to production.)

GeoffFroh commented 5 years ago

Tested against ddr-densho-379 and ddr-densho-397. Left signature empty intentionally in ddr-densho-379 to make certain there were changes to make.

Running ddr-signatures from command-line on ddr-densho-379 did not work. But later tried in webui and that did work.

gjost commented 5 years ago

Left signature empty intentionally in ddr-densho-379 to make certain there were changes to make.

The collection's status is "inprocess". A small number of entity records are marked non-public. The signature chooser currently only chooses signatures for items that are public and completed. Do we want to revise this behavior?

OBJECT ID (STATUS, PUBLIC) ddr-densho-379 (inprocess, 1) ddr-densho-379-207 (completed, 0) ddr-densho-379-206 (completed, 0) ddr-densho-379-205 (completed, 0) ddr-densho-379-204 (completed, 0) ddr-densho-379-203 (completed, 0) ddr-densho-379-202 (completed, 0)

OBJECT ID (STATUS, PUBLIC) ddr-densho-397 (inprocess, 1) ddr-densho-397-18 (inprocess, 1)

GeoffFroh commented 5 years ago

No. Signatures should always be created — they are used in the editor interface all the time by the archivists. No signatures == more useless clicking.

On May 15, 2019, at 12:43 PM, Geoffrey Jost notifications@github.com wrote:

Left signature empty intentionally in ddr-densho-379 to make certain there were changes to make.

The collection's status is "inprocess". A small number of entity records are marked non-public. The signature chooser currently only chooses signatures for items that are public and completed. Do we want to revise this behavior?

OBJECT ID (STATUS, PUBLIC) ddr-densho-379 (inprocess, 1) ddr-densho-379-207 (completed, 0) ddr-densho-379-206 (completed, 0) ddr-densho-379-205 (completed, 0) ddr-densho-379-204 (completed, 0) ddr-densho-379-203 (completed, 0) ddr-densho-379-202 (completed, 0)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

gjost commented 5 years ago

Got it, will change the behavior.

gjost commented 5 years ago

Fixed (hopefully) in ddr-cmdln commit 964bd4e for package ddrlocal-develop_2.8.4a or later.

GeoffFroh commented 5 years ago

@pkikawa, please test, then close this issue.

pkikawa commented 5 years ago

tested and working on 284aDEV

pkikawa commented 5 years ago

working 286MA