denshoproject / ddr-cmdln

Command-line tools for automating the Densho Digital Repository's various processes.
Other
0 stars 2 forks source link

ddr-pubcopy not copying files from original directory to target directory #167

Closed sarabeckman closed 5 years ago

sarabeckman commented 5 years ago

ddr-pubcopy output in 2.8.10 master: ddr-pubcopy_output_2810_MA.txt

ddr-pubcopy output in 2.8.9 MA ddr-pubcopy_output_289_MA.txt

In 2.8.10 MA the destination directory is created in /media/qnfs/kinkura/transfer/ but no binary files are copied to it. The command calls for different arguments from previously. Listing the file types to copy instead of a flag.

In 2.8.9 MA the binary files are successfully copied to the transfer directory. The command uses the old arguments the -mat flags.

GeoffFroh commented 5 years ago

related to #161

sarabeckman commented 5 years ago

Tested ddr-pubcopy on Maunakea (10.0.1.17) We got the following Traceback error (in text document). ddr-pubcopy_output_Maunakea.txt

Geoff made a symlink between /var/www/media/ddr and /media/qnfs/kinkura/gold/. Once we did that we were able to verify and replicate the same results I got from my local VM running 2.8.10 MA.

GeoffFroh commented 5 years ago

Tested with the ddr-densho-365 repo that @sarabeckman used in original issue test. Confirmed same behavior, however, using --force flag did work.

There is something amiss with the logic in can_publish:

https://github.com/densho/ddr-cmdln/blob/master/ddr/bin/ddr-pubcopy#L116

It's a type mismatch with the public flags -- they are string values in entity.json

This gist seemed to work (tested with same collection): https://gist.github.com/GeoffFroh/675dfd258299923f326b8ac5ea177354

gjost commented 5 years ago

Fixed in ddr-cmdln commit 58151d7 for package ddrlocal-develop_2.8.9-4.

sarabeckman commented 5 years ago

ddr-pubcopy_traceback_28910Dev.txt Ran ddr-pubcopy running ddrlocal-develop_2.8.9-4 on my local VM. I received the above Error Traceback.

gjost commented 5 years ago

This is a separate issue: https://github.com/densho/ddr-local/issues/265

sarabeckman commented 5 years ago

Successfully ran ddr-pubcopy on ddr-develop_2.8.9-5.