`DDR.identifier.Definitions.valid_components` should get list of orgs from `ddr/repository.json`

denshoproject / ddr-cmdln

Command-line tools for automating the Densho Digital Repository's various processes.

Other

0 stars 2 forks source link

`DDR.identifier.Definitions.valid_components` should get list of orgs from `ddr/repository.json` #240

Closed gjost closed 5 months ago

gjost commented 8 months ago

DDR.identifier.Definitions.valid_components currently gets its list of organizations from ddr-defs:repo_models/identifier.py. This means there are multiple sources of truth for this list.

Afterwards there will still be multiple sources of truth that must agree with each other (

gitolite-admin/conf/gitolite-admin.conf
ddr-idservice.

) but this will minimize that number.

Remember to update the unit test as well.

gjost commented 8 months ago

According to the src, DDR.identifier.Definitions.valid_components was getting its list of organizations from repository.json. The docstring said you could override it in ddr-defs:repo_models/identifier.py but that was false.