denshoproject / ddr-cmdln

Command-line tools for automating the Densho Digital Repository's various processes.
Other
0 stars 2 forks source link

`ddr-import file` (ingest.py) does not function across mounted file systems #47

Closed GeoffFroh closed 6 years ago

GeoffFroh commented 6 years ago

ddr-import file fails when trying to import files when the targeted repo is on non-local storage (i.e., nfs mount). The error is:

OSError: [Errno 18] Invalid cross-device link

Resolution: ingest.py should use shutil.move instead of os.rename. See:

https://github.com/densho/ddr-cmdln/blob/00d6bf004a20c921f921fa5f28616ce642a51958/ddr/DDR/ingest.py#L209

*(We should probably find and replace all instances of os.rename in ddr-cmdln -- this has shown up in the past and was fixed in ddr-pubcopy)

gjost commented 6 years ago

Fixed in c58fcaf.