search

denshoproject / ddr-cmdln

Command-line tools for automating the Densho Digital Repository's various processes.
Other
0 stars 2 forks source link

ddrimport entity hanging on Identifier #90

Closed sarabeckman closed 5 years ago

sarabeckman commented 6 years ago

ddrimportentitybug

ddrimport entity is not moving past the first DDR.identifier.Identifier collection step. The process doesn't stop and I have to manually cancel out of the operation.

I'm running master version 2.6.1 on my local VM. My local VM is also running stretch.

gjost commented 6 years ago

I confirmed that contents of the log on kinkura agree with the screenshot. I copied the CSV to my local dev environment and ran it on a local copy of that collection but was not able to duplicate the error.

Before we do anything else, can you update your copy of ddrlocal? It's a couple versions behind.

sarabeckman commented 6 years ago

I updated my copy to version 2.6.3 and I tried running the same ddrimport entity command and I got the same result.

gjost commented 6 years ago

I've downloaded both the CSV (ddr-csujad-14-entities-20180501-1049.csv) and the repository itself from kinkura to my local system. I also rolled back all the DDR components (ddr-defs, ddr-cmdln, ddr-local) to the where they are in 2.6.3 and recompiled everything from scratch. Unfortunately I still haven't been able to duplicate this bug. Next I'll look through the source code and see what's going on at the point where it seems to get stuck. If that doesn't work I'll install on a Debian Stretch system and see if that makes a difference.

gjost commented 6 years ago

In future bug reports, it's better to cut-and-paste text from the terminal rather than take screenshots. This makes it a lot easier to work with paths and stuff, cut-and-paste rather than squint and type.

Thanks for including the version number and the host OS.

gjost commented 6 years ago

I notice the command does not include the ID service username or password. Did you have these in environment variables, e.g. export IDSERVICE_ENVIRONMENT_USERNAME=redacted?

I ask because the very next thing that happens after the collection identifier gets printed (the last thing before it hangs) is the ID service login. If username is not in an environment variable, you'll get a username prompt.

Once ddrimport has a username/password, it attempts to contact the ID service. What happens if you run elinks https://idservice.densho.org on that VM? You should see a popup, where you should select "show header". You should then see some JSON. If you can't see this, you have a bad connection with the ID service.

sarabeckman commented 6 years ago

Aha! okay I added my ID service username and password to the command and the command worked!

gjost commented 6 years ago

Awesome! I guess i need to make it complain and quit if it doesnt have that info.

On September 7, 2018 11:51:56 AM PDT, Sara Beckman notifications@github.com wrote:

Aha! okay I added my ID service username and password to the command and the command worked!

-- You are receiving this because you were assigned. Reply to this email directly or view it on GitHub: https://github.com/densho/ddr-cmdln/issues/90#issuecomment-419532616

-- "Work as if you live in the early days of a better national. --Alasdair Gray

gjost commented 5 years ago

Fixed in 9906b50.

gjost commented 5 years ago

Fixed in ea770a6.