search

denshoproject / ddr-local

Web UI used for interacting with DDR collections and entities on a local machine.
Other
3 stars 0 forks source link

cannot delete child entities #251

Closed pkikawa closed 5 years ago

pkikawa commented 5 years ago

found on version Dana's local 2.7.1MA, deleting child entity resulted in TypeError. confirmed on PYK's vm as well

local.log TypeError at _ui_entity_ddr-densho-1000-449-18delete.txt

GeoffFroh commented 5 years ago

Not actually a defect -- the functionality to delete child entities was discussed, but not implemented.

GeoffFroh commented 5 years ago

The delete function for a child entity would need to remove any files attached to the entity, then update the parent entity's children list to remove the reference to the child entity, and finally delete the entity itself.

GeoffFroh commented 5 years ago

see: https://github.com/densho/ddr-local/issues/252

gjost commented 5 years ago

Completed as of commit 090facf and commit ae0b8b5 in ddr-cmdln.