GeoffFroh
commented
4 years ago Entities displaying error behavior:
ddr-densho-1003-1 -- ddr-densho-1003-9 ddr-densho-1003-11 -- ddr-densho-1003-16 ddr-densho-1001-2 ddr-densho-1000-1 -- ddr-densho-1000-18 ddr-densho-1000-20 -- ddr-densho-1000-25
Entities tested known not to display error behavior:
ddr-densho-1003-10 (NOTE: this interview is missing transcript data) ddr-densho-1000-19
TODO:
- [x] Test other interview entities in ddr-densho-1003 (@pkikawa, @sarabeckman)
- [x] Test other interview entities in ddr-densho-1001 (@pkikawa)
- [x] Check other collections with segment-type entities (we have not seen this behavior with entities that do not have child segments) (@pkikawa)
- [x] Locate code block where the sorting occurs (is this actually in https://github.com/denshoproject/ddr-cmdln?) (@gjost)
- [x] Examine entity.json data for ddr-densho-1003 (@GeoffFroh)
gjost
pkikawa
2020-08-19 15:46 @sarabeckman reports problem displaying ddr-densho-1003-9 using local VM running 5.0.11. TypeError at _ui_entityddr-densho-1003-9.zip
15:53 @gjost gjost it's trying to sort entities against files. what are you trying to do? 15:54 @sarabeckman This happened the first time I'm trying to look at the entity in editor 15:55 So I clicked into the collection, then the page with the object list, then clicked on entity 9 and got this error 15:57 @gjost gjost can you look at other entities? in other collections? 15:57 @sarabeckman let me try real quick 15:59 alright I was able to look at entities in a photo/doc collection ddr-densho-371 15:59 However I tried another VH collection ddr-densho-1001-2 and I got the same sort of error 16:02 @gjost well see if you can find some pattern 16:03 @sarabeckman Could it be caused by html tags being used in the description? 16:04 @gjost nope, not a problem with the inputs. it's a problem with sorting the IDs. the program splits the IDs into parts and it can't compare an int to a string. 16:04 i'm just curious why we never saw this before. i haven't touched this part of the codebase in forever 16:04 @GeoffFroh can you open any of the entities in ddr-densho-1003? or is just 9? 16:06 @sarabeckman I can load entity 10 16:06 can't load 1-9 16:06 @GeoffFroh Ok — one sec… 16:09 hmmm…I’m flumoxxed. 16:10 @sarabeckman It looks like entity 10 is the only one I can load in ddr-densho-1003 16:10 @gjost i started at 8 today so i'm at my limit 16:11 @sarabeckman okay I'm near my quitting time too. 16:28 @pkikawa 10 is the only entity that doesnt have anything in the "file_groups" field 16:28 1003-1 entity.json 16:28 1003-10 entity.json 16:30 all 1-9 have transcript in the file_group while 10 does not (edited) 16:32 testing now, though i did test transcript files pre-deployment. 08:28 @GeoffFroh I agree — don’t think that’s a related issue 08:32 @pkikawa: to clarify, you are not able to replicate the error that @sara.beckman reported earlier with ddr-densho-1003-1 — ddr-densho-1003-10? i.e., trying to open the entity detail page throws a TypeError exception with the message < not supported between instances of 'str' and 'int' 08:35 @gjost The problem with the sorting is that Python can't sort/compare different types - it can't compare a str and an int. In this case we're comparing an entity and a file for some reason, which wasn't really in the use-case. 08:37 (The Identifier sorting algo compares the internal representation of IDs as lists of str or int. Number segments are turned into int so that they sort numerically rather than as strings.) 08:38 but first we should figure out why it's comparing Entity and File objects. My guess is the Entity has Segment objs