Open gjost opened 1 year ago
There's code in the 314-person-nrids-II
branch that will be useful for this, so initial work will happen on that branch.
Fixed in these commits
ddr-defs
branch 320-oh_ids
, merged into develop
in commit 3d5b30f
ddr-cmdln
branch 320-oh_ids
, merged into develop
in commit 9ae4d49
The new code reads various forms on id
and outputs in person
format as oh_id
Needs testing before merge into master
.
Update ddr-public
use oh_id
but backwards-compatible. NOTE: Requires update to densho-elastictools
.
Changes
ddr-public/ddrpublic/ui/templates/ui/entities/segment(-audio,video).html
ddr-public/ddrpublic/ui/models.py:Narrator.interviews
densho-elastictools/elastictools/search.py:Searcher.prepare
Test OLD format creators.id
:
ddrindex publish ddr-densho-1000-1
with ddrcmdln:master
(creators.id
)creators.id
present in /api/0.2/ddr-densho-1000-1/
/narrator/1/
/interviews/ddr-densho-1000-1-1/
Test NEW format creators.oh_id
:
ddrindex publish ddr-densho-1000-522
with ddrcmdln:320-oh_ids
(creators.oh_id
)creators.oh_id
present in /api/0.2/ddr-densho-1000-522/
/narrator/1014/
/interviews/ddr-densho-1000-522-1/
ddrpublic
oh_id
support complete in commit 6db3ea6
, merged in to master
branch in commit bf05ce1
v6.4.0
When loading objects,
creator.id
should be replaced withcreator.oh_id
("oral history ID"). Clarify once and for all exactly what that ID means.