denshoproject / ddr-local

Web UI used for interacting with DDR collections and entities on a local machine.
Other
3 stars 0 forks source link

Change `creator.id` to `creator.oh_id` ("oral history ID") #320

Open gjost opened 1 year ago

gjost commented 1 year ago

When loading objects, creator.id should be replaced with creator.oh_id ("oral history ID"). Clarify once and for all exactly what that ID means.

gjost commented 1 year ago

There's code in the 314-person-nrids-II branch that will be useful for this, so initial work will happen on that branch.

gjost commented 1 year ago

Fixed in these commits

The new code reads various forms on id and outputs in person format as oh_id

gjost commented 1 year ago

Needs testing before merge into master.

GeoffFroh commented 1 year ago

See related: https://github.com/denshoproject/ddr-cmdln/issues/236

gjost commented 1 year ago

Update ddr-public use oh_id but backwards-compatible. NOTE: Requires update to densho-elastictools.

Changes

Test OLD format creators.id:

Test NEW format creators.oh_id:

gjost commented 1 year ago

ddrpublic oh_id support complete in commit 6db3ea6, merged in to master branch in commit bf05ce1 v6.4.0