search

denshoproject / ddr-local

Web UI used for interacting with DDR collections and entities on a local machine.
Other
3 stars 0 forks source link

255 chars is not enough for Physical Description #340

Open gjost opened 3 months ago

gjost commented 3 months ago

Archivist needs more than 255 chars to describe something. First time in? 10 years?

max_length is set in ddr-defs/repo_models/entity.py and others. We set this because you always set a max length in a form field, right? Because VARCHAR fields (in a database) have character limits. But this is for a JSON document, so don't need to have limits.

GeoffFroh commented 3 months ago

We can remove the limit on the max length for this field, and also change the UI widget to use a TEXTAREA form item instead of a TEXT field.

(We also reviewed the other data attributes in Entity, Collection, and File; those are fine for now)

gjost commented 3 months ago

Made change in commit 758e593 on develop branch.

An earlier change on that branch relating to valid organization keywords should be tested before we push this out to master

gjost commented 3 months ago

Ran unit tests for ddr-cmdln, ddr-local, ddr-public and looks okay

gjost commented 2 months ago

Changes committed in 758e593 and merged in to master.