search on creators.namepart and persons is broken

[gjost]

Mods to ddrpublic on the 199-creators-persons branch:

• Add creators.namepart to SEARCH_PARAM_WHITELIST and SEARCH_INCLUDE_FIELDS
• Added creators and persons fields to ui.forms_search.SearchForm.
• Modified search form to display creators: ... or persons: ... in place of fulltext.

densho-elastictools expects searches to always be based on a fulltext field. This branch enables searches based on creators.namepart and persons fields instead of fulltext. Unfortunately these fields are tokenized (elasticsearch_dsl.Keyword instead of elasticsearch_dsl.Text) and can't be mixed with a fulltext search without some more refactoring.

The team thought this change was going in a wrong direction, that users would expect to be able to type names and get results from title, description, and other fields along with results from creators.namepart, all using fulltext search. To make that work, we will need to create a separate elasticsearch_dsl.Text field that contains the text from creators.namepart and make that searchable.

199-creators-persons branch will be kept in place but further work will be on 199-search-hidden.

[gjost]

• ddr-cmdln - Added search_hidden field to Elasticsearch records in branch 199-search-hidden commit e06f3e3.
• ddr-local - Added search_hidden to searchable fields in branch 199-search-hidden commit 6f50622.
• ddr-local - models: Add creators search and NamesDB links on detail pages in branch 199-search-hidden commit 9da62de.

[gjost]

creators and persons are now searched using fulltext searching via the search_hidden field.

Fixed in ddr-public commit a03701e, merged in to develop branch, pulled to ddrstage.densho.org

[gjost]

Some ideas:

• Add creators.role, creators.namepart, and persons.namepart to aggregations along with topics, genre, etc.?
• If .role or a .namepart is the only search term, do a filter search like we do for topics. If there's a fulltext field, do a fulltext search with name as a filter.