search

denshoproject / encyc-front

front-end interface for the encyclopedia
Other
1 stars 0 forks source link

Map not rendering locations #75

Closed GeoffFroh closed 4 years ago

GeoffFroh commented 4 years ago

The map (https://encyclopedia.densho.org/map/#) is no longer displaying locations. The section of the template that should be rendering the location data that is consumed by the front-end javascript is not functioning (https://github.com/densho/encyc-front/blob/master/front/locations/templates/locations/locations.html#L216).

gjost commented 4 years ago

Confirmed.

GeoffFroh commented 4 years ago

bad data in densho-vocab:/api/0.2/facilities.xml

gjost commented 4 years ago

Problem was some bad data in densho-vocab. This caused encyc-psms to crash when trying to display data in the API. The data has been updated so things look OK now.

A partial fix in encyc-psms commit 10efcd7 for package encycpsms-master~1.1.5 makes PSMS more tolerant of missing data. This doesn't totally fix the problem because that moves the problem to encyc-front.

The other part of the fix will be to mod encyc-front front/locations/templates/locations/locations.html so that missing data is noted in comments in the HTML. This way the page will still mostly work even with missing data.