search

denshoproject / encyc-front

front-end interface for the encyclopedia
Other
1 stars 0 forks source link

"From the Archive" sidebar media pop-up does not work for non-OH AV materials #81

Closed GeoffFroh closed 3 years ago

GeoffFroh commented 4 years ago

When a "From the Archive" media item is a non-oral history audio-visual object, the AV player does not render in the lightview pop-up box as expected. This behavior pertains only to items that are dynamically populated in the "From the Archive" sidebar feature on the article detail page. The links in the FTA "more info" page function properly.

See:

https://encyclopedia.densho.org/Japanese_associations/

gjost commented 4 years ago

fwiw on the old production site (encycfront-master-2.5.10) all these pop-up links returned 403 errors.

gjost commented 4 years ago

These popups have never been media players; as long as we've had the popups they've displayed the thumbnails (see ddr-object.html). The related-ddr.html page also just lists thumbnails. The media playing happens over on the DDR site.

Are you asking to add DDR players to the Encyclopedia?

gjost commented 4 years ago

Apropos of not much, while investigating this I took a look at the Lightview pop-up js we're using. Looks like it is no longer supported. The Lightview link on the author's personal site returns a 404. Lightview does not appear among his repositories on GitHub. The lightviewjs twitter account hasn't been updated since 2014.

gjost commented 4 years ago

Personally I've always thought the FTA thumbnails should be links to anchors for the corresponding items on the From the DDR page.

GeoffFroh commented 3 years ago

See https://github.com/denshoproject/encyc-front/issues/107