search

denshoproject / encyc-front

front-end interface for the encyclopedia
Other
1 stars 0 forks source link

Urls to DDR objects on Source detail pages are malformed #90

Closed GeoffFroh closed 4 years ago

GeoffFroh commented 4 years ago

Urls pointing at objects from the DDR on Source detail pages are malformed. See, for example:

https://encycstage.densho.org/sources/en-ddr-densho-266-32-23-1/

DDR ID is malformed in url between the image and the caption:

http://ddr.densho.org/ddr/densho/266/32/ should be http://ddr.densho.org/ddr-densho-266-32/

gjost commented 4 years ago

The external_url field in Elasticsearch is malformed:

    external_url: "http://ddr.densho.org/ddr/densho/266/32/",

Fix in encyc-core.

gjost commented 4 years ago

Many Source records in the PSMS (the ones that point to DDR) have the URL formatted this way. I think this is a previous DDR URL format. Note: there are many records which point elsewhere e.g. log.gov. I'll write a regex in encyc-core that reformats the DDR URLs.

gjost commented 4 years ago

Fixed in encyc-core commit a8fb961 for package encyccore-master_4.0.4~deb9.

pkikawa commented 4 years ago

fixed.