Closed taraschornyiplv closed 3 years ago
@taraschornyiplv Would it make more sense to pull v3.0.1 instead?
The hashes in the merge/pull request summary do not match the hashes in the branch (after the latest pushes).
Closed/reopened this PR since DCO was stuck
I don't think Closing/Reopening this PR worked.
Taras, you might need to try force pushing a new update in this PR but I have seen this issue and I don't think that would work. From past experiences, whenever this happens due to a DCO downtime, GH team always asks us to create a new PR.
ok I will force push
@eladnachman, why did you merge it, despite changes were still requested? Please, do thorough reviews and keep in mind, that maintaining patches on top is a lot of work and decreases quality as upstream reviews are missing.
Merge was done following multiple reviews of multiple people (including myself) of the the kernel patches. I have reviewed the patches myself at least 3 times. I am not aware of any open outstanding changes. Upstreaming is a very long process and should be done in parallel in order to prevent delays to the development cycle.
Upstreaming is a very long process and should be done in parallel in order to prevent delays to the development cycle.
Some of the commits were authored over half a year ago in February 2021, so it’s not happening in parallel. The network subsystem (net) changes look to me like, could have been easily sent upstream already. It looks to me, some processes are not set up optimally, if upstreaming seems to be such a problem.
Switchdev Driver v3.0.0 features included:
List of commit in this PR: