dentproject / dentOS

dentOS SwitchDev based NOS
Other
202 stars 59 forks source link

[PATCH] net: phylink: sfp: Add quirk for FINISAR 10G modules #146

Closed Mickey201 closed 2 years ago

Mickey201 commented 2 years ago

Finisar FTLF8536P4BCL and FTLX1471D3BCL can operate in 1000Base-x mode as well Tested on Accton AS5114 platform.

Signed-off-by: Mickey Rachamim mickeyr@marvell.com

Mickey201 commented 2 years ago

As for the failed "DentOS Verify" failure. According to the Jenkins report console: https://jenkins.dent.dev/job/dentos-verify-main/90/console

One of the build commands failed with the below message: 15:14:46 ---> dentos-build.sh 15:14:46 + sudo apt-get install -y binfmt-support 15:14:46 sudo: apt-get: command not found 15:14:46 Build step 'Execute shell' marked build as failure

Not fully clear to us why it happens... @sonoble - may you please restart the build process to confirm it was not just a specific server issue?

taraschornyiplv commented 2 years ago

recheck

taraschornyiplv commented 2 years ago

For some DentOS verify was executed on centos build host rather than Ubuntu/Debian.

keanjapesan commented 2 years ago

recheck

keanjapesan commented 2 years ago

recheck

sonoble commented 2 years ago

The wrong OS is being used. Apt is failing.

keanjapesan commented 2 years ago

recheck

robimarko commented 2 years ago

CentOS7 is being used for whatever reason instead of Debian. @jwagantall Any ideas?

keanjapesan commented 2 years ago

@sonoble @robimarko @taraschornyiplv the job configuration was set with a CentOS node, no idea how it was working before, so the solution is to change the node name from ci-management repo to "prd-ubuntu-docker-aws-1c-2g". Yesterday, for testing purposes I was running some rechecks with the Ubuntu image and we found some troubles on the first attempts until we finally got it working. However the permanent fix is still pending so please push a PR modifying the following line https://github.com/dentproject/ci-management/blob/master/jjb/dentos/dentos.yaml#L10 with "prd-ubuntu-docker-aws-1c-2g"

snobleaws commented 2 years ago

@Mickey201 github is complaining that this is not signed.

Mickey201 commented 2 years ago

Applying Paul comment. Now with GPG signoff. @sonoble , @taraschornyiplv , please review.

Mickey201 commented 2 years ago

@keanjapesan, the build failed again for the same reason: 23:48:03 + sudo apt-get install -y binfmt-support 23:48:03 sudo: apt-get: command not found

taraschornyiplv commented 2 years ago

recheck

snobleaws commented 2 years ago

The failure appears to be an issue with the patch?

17:56:29 Applying: 0042-net-phylink-sfp-Add-quirk-for-FINISAR-10G-modules.patch 17:56:29 /w/workspace/dentos-verify-main/packages/base/any/kernels/5.10-lts/patches/0042-net-phylink-sfp-Add-quirk-for-FINISAR-10G-modules.patch: line 1: From: command not found 17:56:29 /w/workspace/dentos-verify-main/packages/base/any/kernels/5.10-lts/patches/0042-net-phylink-sfp-Add-quirk-for-FINISAR-10G-modules.patch: line 2: syntax error near unexpected token newline' 17:56:29 /w/workspace/dentos-verify-main/packages/base/any/kernels/5.10-lts/patches/0042-net-phylink-sfp-Add-quirk-for-FINISAR-10G-modules.patch: line 2:From: Taras Chornyi

Mickey201 commented 2 years ago

Closing this pull request. Something went wrong with the pushed files. Will open a new one that will include all resolved comments.

paulmenzel commented 2 years ago

For completeness, the new merge/pull request is https://github.com/dentproject/dentOS/pull/150.

@Mickey201, it’d be great, if you did that the next time. I know it’s frustrating that QA/CI/… fails, but for people not working on this eight hours a day, it’s very helpful.