dentproject / dentOS

dentOS SwitchDev based NOS
Other
200 stars 59 forks source link

[as4224/as5114] Add CPLD sub_version in onlp_sysi_platform_info_get() #153

Closed brandonchuang closed 2 years ago

brandonchuang commented 2 years ago

Signed-off-by: Brandon Chuang brandon_chuang@edge-core.com

paulmenzel commented 2 years ago

Please amend the commit message (and force push) and elaborate, what the problem is.

brandonchuang commented 2 years ago

Amended.

paulmenzel commented 2 years ago

Thank you.

The sub version is also required.

What is it required for?

brandonchuang commented 2 years ago

Thank you.

The sub version is also required.

What is it required for?

The sub version is defined in the CPLD spec. (Register 0xFF) I missed the field before and customer asked for it.

paulmenzel commented 2 years ago

Please change

The sub version is also required.

to

A sub version also exists, so display it too, as it’s good to have for informational purposes.

brandonchuang commented 2 years ago

Please change

The sub version is also required.

to

A sub version also exists, so display it too, as it’s good to have for informational purposes.

Done.