search

dentproject / dentOS

dentOS SwitchDev based NOS
Other
200 stars 58 forks source link

Update DentOS to debian10 #216

Closed taraschornyiplv closed 10 months ago

taraschornyiplv commented 1 year ago

Update DentOS to Debian 10:

Arm64 image can be found here: https://repos.refinery.dev/repository/dent/snapshots/org/dent/dentos/dentos-verify-main/DENTOS-HEAD_ONL-OS10_2023-05-30.1233-2f62b8d_ARM64_INSTALLED_INSTALLER

Supported platforms:

taraschornyiplv commented 1 year ago

reverify

DhruvJ225 commented 1 year ago

reverify

taraschornyiplv commented 1 year ago

Thank you for working on this. Some questions:

  1. Why not go straight to Debian 11 or 12?
  2. It’d be great if you elaborated in the commit messages.
  3. Typo: Remove unsupported devises → devi_c_es
  4. It’d be great if you added a section about the devices you tested this on, and what difference you noticed (boot time, performance, …).

With Debian 11 or 12 a lot of python2 onl code has to be updated. Will fix typo.

taraschornyiplv commented 1 year ago

Test results for AS5114 platform can be found here

KanjiMonster commented 12 months ago

Fails to build for me on ubuntu 22.04:

I: Setting /home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/lib64 -> /home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/lib symbolic link.
Getting package lists: APT_CONFIG=/tmp/multistrap.JoK13i apt-get  -o Apt::Architecture=arm64 -o Dir::Etc::TrustedParts=/home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/etc/apt/trusted.gpg.d -o Dir::Etc::Trusted=/home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/etc/apt/trusted.gpg -o Apt::Get::AllowUnauthenticated=true -o Acquire::AllowInsecureRepositories=true -o Apt::Get::Download-Only=true -o Apt::Install-Recommends=false -o Dir=/home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/ -o Dir::Etc=/home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/etc/apt/ -o Dir::Etc::Parts=/home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/etc/apt/apt.conf.d/ -o Dir::Etc::PreferencesParts=/home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/etc/apt/preferences.d/ -o APT::Default-Release='*' -o Dir::State=/home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/var/lib/apt/ -o Dir::State::Status=/home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/var/lib/dpkg/status -o Dir::Cache=/home/ubuntu/dentOS/builds/arm64/rootfs/builds/buster/rootfs-arm64.d/var/cache/apt/ update
Ign:1 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ InRelease
Ign:2 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ InRelease
Ign:3 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Release
Ign:4 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Release
Ign:5 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Packages
Ign:6 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Translation-en
Ign:7 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Packages
Ign:8 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Translation-en
Ign:5 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Packages
Ign:6 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Translation-en
Ign:7 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Packages
Ign:8 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Translation-en
Ign:5 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Packages
Ign:6 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Translation-en
Ign:7 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Packages
Ign:8 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Translation-en
Ign:5 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Packages
Ign:6 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Translation-en
Ign:7 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Packages
Ign:8 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Translation-en
Ign:5 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Packages
Ign:6 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Translation-en
Ign:7 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Packages
Ign:8 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Translation-en
Ign:5 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Packages
Ign:6 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Translation-en
Ign:7 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Packages
Ign:8 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Translation-en
Get:5 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Packages [3334 B]
Ign:6 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Translation-en
Err:7 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Packages
  Failed to stat - stat (2: No such file or directory)
Ign:8 copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Translation-en
Get:9 http://127.0.0.1:3142/mirrors.kernel.org/debian buster InRelease [122 kB]
Ign:9 http://127.0.0.1:3142/mirrors.kernel.org/debian buster InRelease
Get:10 http://127.0.0.1:3142/mirrors.kernel.org/debian buster/main arm64 Packages [7737 kB]
Get:11 http://127.0.0.1:3142/mirrors.kernel.org/debian buster/main Translation-en [5969 kB]
Fetched 13.8 MB in 2s (5730 kB/s)                                
Reading package lists... Done
W: The repository 'copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-all ./ Release' does not have a Release file.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
W: The repository 'copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64 ./ Release' does not have a Release file.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
W: GPG error: http://127.0.0.1:3142/mirrors.kernel.org/debian buster InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 648ACFD622F3D138 NO_PUBKEY 0E98404D386FA1D9 NO_PUBKEY DCC9EFBF77E11517
W: The repository 'http://127.0.0.1:3142/mirrors.kernel.org/debian buster InRelease' is not signed.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
E: Failed to fetch copy:/home/ubuntu/dentOS/REPO/buster/packages/binary-arm64/./Packages  Failed to stat - stat (2: No such file or directory)
E: Some index files failed to download. They have been ignored, or old ones used instead.
apt update failed. Exit value: 100
INFO:onlrfs:[profiler] sudo /usr/sbin/multistrap -d buster/rootfs-arm64.d -f /tmp/tmpyVMNAr : 3.42871403694 seconds (0.057145233949 minutes)
DEBUG:onlrfs:Executing:sudo mount -t devtmpfs dev buster/rootfs-arm64.d/dev
INFO:onlrfs:[profiler] sudo mount -t devtmpfs dev buster/rootfs-arm64.d/dev : 0.0115509033203 seconds (0.000192515055339 minutes)
DEBUG:onlrfs:Executing:sudo mount -t proc proc buster/rootfs-arm64.d/proc
mount: buster/rootfs-arm64.d/proc: mount point does not exist.
ERROR:onlrfs:Exception 'Could not mount proc in rfs.' in OnlRfsContext::__enter__
DEBUG:onlrfs:Executing:sudo umount -l buster/rootfs-arm64.d/dev buster/rootfs-arm64.d/proc
umount: buster/rootfs-arm64.d/proc: no mount point specified.
ERROR:onlrfs:Could not unmount dev and proc
make[3]: *** [/home/ubuntu/dentOS/make/rfs.mk:51: RFS] Error 1
ERROR:onlpm:'Build failed.'
make[2]: *** [/home/ubuntu/dentOS/make/pkg.mk:30: pkgall] Error 1
make[1]: *** [/home/ubuntu/dentOS/make/subdirs.mk:15: all] Error 1
make[1]: Leaving directory '/home/ubuntu/dentOS/builds/arm64'
make: *** [Makefile:23: arm64] Error 2
make: *** [Makefile:57: docker] Error 2
KanjiMonster commented 12 months ago

Using a fresh checkout it worked. Must have been some leftovers somewhere from the previous build with debian 9 (though no idea where, since I did a git clean).

KanjiMonster commented 12 months ago

Booted the image and was greeted with a scary:

[FAILED] Failed to start Advanced I…1X/WPA/WPA2/EAP Authenticator.

in the boot log. Looking at the journal

Jul 19 15:14:12 localhost systemd[1]: Starting Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator...
Jul 19 15:14:12 localhost hostapd[1293]: Configuration file: /etc/hostapd/hostapd.conf
Jul 19 15:14:12 localhost hostapd[1293]: Could not open configuration file '/etc/hostapd/hostapd.conf' for reading.
Jul 19 15:14:12 localhost hostapd[1293]: Failed to set up interface with /etc/hostapd/hostapd.conf
Jul 19 15:14:12 localhost hostapd[1293]: Failed to initialize interface
Jul 19 15:14:12 localhost systemd[1]: hostapd.service: Control process exited, code=exited, status=1/FAILURE
Jul 19 15:14:12 localhost systemd[1]: hostapd.service: Failed with result 'exit-code'.
Jul 19 15:14:12 localhost systemd[1]: Failed to start Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Jul 19 15:14:14 localhost systemd[1]: hostapd.service: Service RestartSec=2s expired, scheduling restart.
Jul 19 15:14:14 localhost systemd[1]: hostapd.service: Scheduled restart job, restart counter is at 1.
Jul 19 15:14:14 localhost systemd[1]: Stopped Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Jul 19 15:14:14 localhost systemd[1]: Starting Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator...
Jul 19 15:14:14 localhost hostapd[1426]: Configuration file: /etc/hostapd/hostapd.conf
Jul 19 15:14:14 localhost hostapd[1426]: Could not open configuration file '/etc/hostapd/hostapd.conf' for reading.
Jul 19 15:14:14 localhost hostapd[1426]: Failed to set up interface with /etc/hostapd/hostapd.conf
Jul 19 15:14:14 localhost hostapd[1426]: Failed to initialize interface
Jul 19 15:14:14 localhost systemd[1]: hostapd.service: Control process exited, code=exited, status=1/FAILURE
Jul 19 15:14:14 localhost systemd[1]: hostapd.service: Failed with result 'exit-code'.
Jul 19 15:14:14 localhost systemd[1]: Failed to start Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Jul 19 15:14:16 localhost systemd[1]: hostapd.service: Service RestartSec=2s expired, scheduling restart.
Jul 19 15:14:16 localhost systemd[1]: hostapd.service: Scheduled restart job, restart counter is at 2.
Jul 19 15:14:16 localhost systemd[1]: Stopped Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Jul 19 15:14:16 localhost systemd[1]: Starting Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator...
Jul 19 15:14:16 localhost hostapd[1427]: Configuration file: /etc/hostapd/hostapd.conf
Jul 19 15:14:16 localhost hostapd[1427]: Could not open configuration file '/etc/hostapd/hostapd.conf' for reading.
Jul 19 15:14:16 localhost hostapd[1427]: Failed to set up interface with /etc/hostapd/hostapd.conf
Jul 19 15:14:16 localhost hostapd[1427]: Failed to initialize interface
Jul 19 15:14:16 localhost systemd[1]: hostapd.service: Control process exited, code=exited, status=1/FAILURE
Jul 19 15:14:16 localhost systemd[1]: hostapd.service: Failed with result 'exit-code'.
Jul 19 15:14:16 localhost systemd[1]: Failed to start Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Jul 19 15:14:18 localhost systemd[1]: hostapd.service: Service RestartSec=2s expired, scheduling restart.
Jul 19 15:14:18 localhost systemd[1]: hostapd.service: Scheduled restart job, restart counter is at 3.
Jul 19 15:14:18 localhost systemd[1]: Stopped Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Jul 19 15:14:18 localhost systemd[1]: Starting Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator...
Jul 19 15:14:18 localhost hostapd[1428]: Configuration file: /etc/hostapd/hostapd.conf
Jul 19 15:14:18 localhost hostapd[1428]: Could not open configuration file '/etc/hostapd/hostapd.conf' for reading.
Jul 19 15:14:18 localhost hostapd[1428]: Failed to set up interface with /etc/hostapd/hostapd.conf
Jul 19 15:14:18 localhost hostapd[1428]: Failed to initialize interface
Jul 19 15:14:18 localhost systemd[1]: hostapd.service: Control process exited, code=exited, status=1/FAILURE
Jul 19 15:14:18 localhost systemd[1]: hostapd.service: Failed with result 'exit-code'.
Jul 19 15:14:18 localhost systemd[1]: Failed to start Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Jul 19 15:28:06 localhost systemd[1]: hostapd.service: Service RestartSec=2s expired, scheduling restart.
Jul 19 15:28:06 localhost systemd[1]: hostapd.service: Scheduled restart job, restart counter is at 4.
Jul 19 15:28:06 localhost systemd[1]: Stopped Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Jul 19 15:28:06 localhost systemd[1]: Starting Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator...
...

it looks like it is stuck in a restart loop.

KanjiMonster commented 12 months ago

Somehow with the switch to debian 10, FRR got downgraded from 8.5 to 6.0.2.

KanjiMonster commented 12 months ago

I did a comparison via apt list --installed, and found the following differences:

A few packages got removed (ignoring those with a version it in their name with a replacement package), some expectedly:

cron
dbus
dentos-poe-agent
dh-python
distro-info-data
e2fslibs
iproute
libfile-copy-recursive-perl
libjs-jquery
libjs-sphinxdoc
libjs-underscore
liblogging-stdlog0
libssl1.0.2
libustr-1.0-1
libyang2
lsb-release
mft
multiarch-support
onl-kernel-5.10-lts-arm64-all-modules
onl-kernel-5.6-lts-arm64-all-modules
onlp-arm64-delta-tx4810-r0
onlp-arm64-marvell-ac5x-db-r0
onlp-arm64-nxp-ls1043ardb-r0
onlp-arm64-nxp-ls1046ardb-r0
onlp-arm64-wnc-qsa72-aom-a-48p-r0
onlp-arm64-wnc-qsd61-aom-a-48-r0
onl-platform-config-arm64-delta-tx4810-r0
onl-platform-config-arm64-marvell-ac5x-db-r0
onl-platform-config-arm64-nxp-ls1043ardb-r0
onl-platform-config-arm64-nxp-ls1046ardb-r0
onl-platform-config-arm64-wnc-qsa72-aom-a-48p-r0
onl-platform-config-arm64-wnc-qsd61-aom-a-48-r0
onl-platform-modules-arm64-delta-tx4810
onl-platform-modules-arm64-marvell-ac5x-db
onl-platform-modules-arm64-nxp-ls1043ardb
onl-platform-modules-arm64-nxp-ls1046ardb
onl-platform-modules-arm64-wnc-qsa72-aom-a-48p
onl-platform-modules-arm64-wnc-qsd61-aom-a-48
onl-vendor-config-marvell
onl-vendor-config-nxp
onl-vendor-config-wnc
onl-vendor-marvell-modules
onl-vendor-nxp-modules
onl-vendor-wnc-modules
python3-petunia
python3-pkg-resources
python3-setuptools
python-argcomplete
python-ipaddr
python-pkg-resources
python-repoze.lru
python-routes
realpath
rssh
tknos-firmware

Of which probably the most interesting are 

dentos-poe-agent
python3-petunia

which probably should have been in the image.

And a few packages got downgraded:

For completion sake, the following packages are new in the debian 10 image (some probably are just stuff broken out into their own package):

binutils-aarch64-linux-gnu
binutils-common
fdisk
libargon2-1
libbinutils
libext2fs2
libfstrm0
libi2c0
libirs161
liblmdb0
libmariadb3
libnftnl11
libprotobuf-c1
libpython2-stdlib
libsensors-config
libtirpc-common
libuchardet0
libzstd1
mariadb-common
mysql-common
python2-minimal
python2
python-dmidecode-data
usb.ids

Of course there's the possibility I did something wrong when building my image, but this is what I got with a locally built one.

taraschornyiplv commented 12 months ago

Somehow with the switch to debian 10, FRR got downgraded from 8.5 to 6.0.2.

FRR is installed from http://deb.frrouting.org/frr for stretch and from Debian repos for buster

KanjiMonster commented 12 months ago

Added all the missing repos from https://github.com/dentproject/dentOS/blob/main/builds/any/rootfs/stretch/standard/standard.yml to https://github.com/dentproject/dentOS/blob/main/builds/any/rootfs/buster/standard/standard.yml and changed the security location from archive.debian.org to deb.debian.org since buster isn't archived yet.

Now building an image with hopefully latest FRR 8.5.2 included.

taraschornyiplv commented 12 months ago

Added all the missing repos from https://github.com/dentproject/dentOS/blob/main/builds/any/rootfs/stretch/standard/standard.yml to https://github.com/dentproject/dentOS/blob/main/builds/any/rootfs/buster/standard/standard.yml and changed the security location from archive.debian.org to deb.debian.org since buster isn't archived yet.

Now building an image with hopefully latest FRR 8.5.2 included.

yes this should include the latest stable frr from http://deb.frrouting.org/frr

taraschornyiplv commented 12 months ago
  • lldpd from 1.0.5-2 to 1.0.3-1+b1
  • python3-pyroute2 from 0.5.14-1 to 0.5.2-1

these packages are installed from pre-build binaries from dent-atrifacts repo for stretch and from Debian repos for buster https://github.com/dentproject/dent-artifacts/blob/master/REPO/stretch/packages/binary-all/python3-pyroute2_0.5.14-1_all.deb https://github.com/dentproject/dent-artifacts/blob/master/REPO/stretch/packages/binary-arm64/lldpd_1.0.5-2_arm64.deb

KanjiMonster commented 12 months ago
  • lldpd from 1.0.5-2 to 1.0.3-1+b1
  • python3-pyroute2 from 0.5.14-1 to 0.5.2-1

these packages are installed from pre-build binaries from dent-atrifacts repo for stretch and from Debian repos for buster https://github.com/dentproject/dent-artifacts/blob/master/REPO/stretch/packages/binary-all/python3-pyroute2_0.5.14-1_all.deb https://github.com/dentproject/dent-artifacts/blob/master/REPO/stretch/packages/binary-arm64/lldpd_1.0.5-2_arm64.deb

https://github.com/lldpd/lldpd/blob/master/NEWS tells me we likely do want to have lldp 1.0.5 and not 1.0.3:

lldpd (1.0.5)
  * Changes:
    + Interface names are also matched for management addresses.
    + On Linux, only register protocol handler for LLDP when only LLDP
      is enabled.
    + Stricter on LLDP incoming frames validation.
    + Add support for VLAN-aware bridges for Linux (no range support). <-- this one looks important
    + Add support for 802.3BT (no SNMP support).
    + Add support for millisecond-grained tx-interval (Jean-Pierre Tosoni).
    + Use generic names for VLAN names, instead of interface names (eg
      vlan100 instead of eth1.100).

or maybe even upgrade to an even newer one, I see several CVEs mentioned in the changes of newer versions.

taraschornyiplv commented 12 months ago
  • lldpd from 1.0.5-2 to 1.0.3-1+b1
  • python3-pyroute2 from 0.5.14-1 to 0.5.2-1

these packages are installed from pre-build binaries from dent-atrifacts repo for stretch and from Debian repos for buster https://github.com/dentproject/dent-artifacts/blob/master/REPO/stretch/packages/binary-all/python3-pyroute2_0.5.14-1_all.deb https://github.com/dentproject/dent-artifacts/blob/master/REPO/stretch/packages/binary-arm64/lldpd_1.0.5-2_arm64.deb

https://github.com/lldpd/lldpd/blob/master/NEWS tells me we likely do want to have lldp 1.0.5 and not 1.0.3:

lldpd (1.0.5)
  * Changes:
    + Interface names are also matched for management addresses.
    + On Linux, only register protocol handler for LLDP when only LLDP
      is enabled.
    + Stricter on LLDP incoming frames validation.
    + Add support for VLAN-aware bridges for Linux (no range support). <-- this one looks important
    + Add support for 802.3BT (no SNMP support).
    + Add support for millisecond-grained tx-interval (Jean-Pierre Tosoni).
    + Use generic names for VLAN names, instead of interface names (eg
      vlan100 instead of eth1.100).

or maybe even upgrade to an even newer one, I see several CVEs mentioned in the changes of newer versions.

I think we should start with 1.0.5 and possibly update to the latest. however, i do not want to keep al these changes in one PR. My plan is to merge basic upgrade to Debian 10 and update packages as new PRs

KanjiMonster commented 12 months ago
  • lldpd from 1.0.5-2 to 1.0.3-1+b1
  • python3-pyroute2 from 0.5.14-1 to 0.5.2-1

these packages are installed from pre-build binaries from dent-atrifacts repo for stretch and from Debian repos for buster https://github.com/dentproject/dent-artifacts/blob/master/REPO/stretch/packages/binary-all/python3-pyroute2_0.5.14-1_all.deb https://github.com/dentproject/dent-artifacts/blob/master/REPO/stretch/packages/binary-arm64/lldpd_1.0.5-2_arm64.deb

https://github.com/lldpd/lldpd/blob/master/NEWS tells me we likely do want to have lldp 1.0.5 and not 1.0.3:

lldpd (1.0.5)
  * Changes:
    + Interface names are also matched for management addresses.
    + On Linux, only register protocol handler for LLDP when only LLDP
      is enabled.
    + Stricter on LLDP incoming frames validation.
    + Add support for VLAN-aware bridges for Linux (no range support). <-- this one looks important
    + Add support for 802.3BT (no SNMP support).
    + Add support for millisecond-grained tx-interval (Jean-Pierre Tosoni).
    + Use generic names for VLAN names, instead of interface names (eg
      vlan100 instead of eth1.100).

or maybe even upgrade to an even newer one, I see several CVEs mentioned in the changes of newer versions.

I think we should start with 1.0.5 and possibly update to the latest. however, i do not want to keep al these changes in one PR. My plan is to merge basic upgrade to Debian 10 and update packages as new PRs

I agree that any updates beyond the versions with the debian 9 base should be separate PRs. There should be just no unexpected downgrades in the switch to debian 10.

taraschornyiplv commented 11 months ago

reverify

taraschornyiplv commented 11 months ago

reverify

rothcar commented 11 months ago

I'm adding @muchetan as a reviewer so that he can weigh in on the test results you posted.

muchetan commented 11 months ago

Looks like these tests are the functional test that were added PLVision. I recommend someone from PLVision to take a look at it,

KanjiMonster commented 11 months ago

We definitely need to either drop hostapd, disable it, or replace it with a working version:

root@localhost:~# sudo journalctl -b -u hostapd | wc -l
293401
root@localhost:~# uptime
 08:52:43 up 16:28,  1 user,  load average: 0.17, 0.04, 0.04

this is ~300k log lines of hostapd refusing to start and systemd trying again and again (insert definition of insanity here):

Aug 04 08:56:25 localhost systemd[1]: hostapd.service: Service RestartSec=2s expired, scheduling restart.
Aug 04 08:56:25 localhost systemd[1]: hostapd.service: Scheduled restart job, restart counter is at 26773.
Aug 04 08:56:25 localhost systemd[1]: Stopped Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Aug 04 08:56:25 localhost systemd[1]: Starting Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator...
Aug 04 08:56:25 localhost hostapd[2114]: Configuration file: /etc/hostapd/hostapd.conf
Aug 04 08:56:25 localhost hostapd[2114]: Could not open configuration file '/etc/hostapd/hostapd.conf' for reading.
Aug 04 08:56:25 localhost hostapd[2114]: Failed to set up interface with /etc/hostapd/hostapd.conf
Aug 04 08:56:25 localhost hostapd[2114]: Failed to initialize interface
Aug 04 08:56:25 localhost systemd[1]: hostapd.service: Control process exited, code=exited, status=1/FAILURE
Aug 04 08:56:25 localhost systemd[1]: hostapd.service: Failed with result 'exit-code'.
Aug 04 08:56:25 localhost systemd[1]: Failed to start Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
taraschornyiplv commented 11 months ago

We definitely need to either drop hostapd, disable it, or replace it with a working version:

root@localhost:~# sudo journalctl -b -u hostapd | wc -l
293401
root@localhost:~# uptime
 08:52:43 up 16:28,  1 user,  load average: 0.17, 0.04, 0.04

this is ~300k log lines of hostapd refusing to start and systemd trying again and again (insert definition of insanity here):

Aug 04 08:56:25 localhost systemd[1]: hostapd.service: Service RestartSec=2s expired, scheduling restart.
Aug 04 08:56:25 localhost systemd[1]: hostapd.service: Scheduled restart job, restart counter is at 26773.
Aug 04 08:56:25 localhost systemd[1]: Stopped Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.
Aug 04 08:56:25 localhost systemd[1]: Starting Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator...
Aug 04 08:56:25 localhost hostapd[2114]: Configuration file: /etc/hostapd/hostapd.conf
Aug 04 08:56:25 localhost hostapd[2114]: Could not open configuration file '/etc/hostapd/hostapd.conf' for reading.
Aug 04 08:56:25 localhost hostapd[2114]: Failed to set up interface with /etc/hostapd/hostapd.conf
Aug 04 08:56:25 localhost hostapd[2114]: Failed to initialize interface
Aug 04 08:56:25 localhost systemd[1]: hostapd.service: Control process exited, code=exited, status=1/FAILURE
Aug 04 08:56:25 localhost systemd[1]: hostapd.service: Failed with result 'exit-code'.
Aug 04 08:56:25 localhost systemd[1]: Failed to start Advanced IEEE 802.11 AP and IEEE 802.1X/WPA/WPA2/EAP Authenticator.

Disabled by default

taraschornyiplv commented 11 months ago

created issues for lldpd #260 and hostapd #261

taraschornyiplv commented 10 months ago

If you change the builder to the expected upstream one (dentproject/builder10:1.3) and stay at Debian 9 for now (until we get the builder built), I'll be fine to merge this.

updated to use https://hub.docker.com/r/dentproject/builder10/tags

taraschornyiplv commented 10 months ago

reverify

ganesasp commented 9 months ago

What is the recommended kernel for use with Debian 10? Is kernel 5.15 ready?

taskin0003 commented 9 months ago

Yes, Dent 3.0 has transitioned to kernel 5.15 back in March, and Dent 3.2 switched to Debian 10 this month. Please check the release notes at

https://github.com/dentproject/dentOS/releases

Thanks,

Taskin

From: Ashwin Ganesh @.> Sent: Wednesday, September 20, 2023 11:35:58 AM To: dentproject/dentOS @.> Cc: taskin0003 @.>; Review requested @.> Subject: Re: [dentproject/dentOS] Update DentOS to debian10 (PR #216)

What is the recommended kernel for us with Debian 10? Is kernel 5.15 ready?

— Reply to this email directly, view it on GitHubhttps://github.com/dentproject/dentOS/pull/216#issuecomment-1728246080, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOITEXCY6F6AVAJFUCUYY7TX3MZQZANCNFSM6AAAAAAYCQ2HRA. You are receiving this because your review was requested.Message ID: @.***>