search

denvaar / jeopardy-game

Create and play your own Jeopardy game board.
34 stars 18 forks source link

Add tests #5

Open denvaar opened 7 years ago

denvaar commented 7 years ago

I've never done front-end unit/integration tests. Help would be appreciated setting that up (enzyme or some other well-used framework) along with at least a couple examples of testing react components.

Thanks!

brooksbecton commented 7 years ago

I have a little experience in jest/enzyme testing and wouldn't mind helping.

I've never done electron stuff though. Is macOS required to run this project?

denvaar commented 7 years ago

@brooksbecton OSX isn't a requirement because electron can run cross-platform, however I have not tried it on any other platform, so you may run into some issues.

brooksbecton commented 7 years ago

@denvaar I have a PR in at #9 . I had to change some of the start scripts to get it to work for me and I think 'electron-prebuilt' has been merged into the main electron package also.

This project has been merged into the electron/electron repository, and the electron module is now published to npm as part of the Electron release process.

https://github.com/electron-userland/electron-prebuilt#electron-prebuilt

I can now use the application on Windows and Linux

As far as testing, are you wanting to go with mocha or jest or do you have a preference? I just saw in #8 that mocha was added. I believe jest/enzyme is supposed to be more of an all in one solution, but mocha has more age on it.

🤷‍♂️ Whatever you want to do :)

brooksbecton commented 7 years ago

I was looking at adding a travis file so that you could see if all the tests pass when someone makes a PR to master.

Is that something you'd want to do?