Closed bpawlak closed 12 years ago
If a user tries to grab the code that appears when clicking "Share" on YouTube, they get an odd 404 error in the iframe and (obviously) can't save the changes. Not being able to save is a good idea, of course, but I'm not sure how we can prevent people from clicking on the "share" option on youtube and grabbing the iframe code</p> <p><a rel="noreferrer nofollow" target="_blank" href="https://docs.google.com/document/d/1oe-nbsMQX4U2G3mcdDyt6uZ8B1vT_DkXJ3ubIIsoylY/edit">https://docs.google.com/document/d/1oe-nbsMQX4U2G3mcdDyt6uZ8B1vT_DkXJ3ubIIsoylY/edit</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jwirfs-brock"><img src="https://avatars.githubusercontent.com/u/1020518?v=4" />jwirfs-brock</a> commented <strong> 12 years ago</strong> </div> <div class="markdown-body"> <p>Maybe we should include some asset-specific help text that tells users they should grab the link instead of the embed code for videos.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ghing"><img src="https://avatars.githubusercontent.com/u/110420?v=4" />ghing</a> commented <strong> 12 years ago</strong> </div> <div class="markdown-body"> <p>Right now, if a user selects the video asset, they're only presented with the video URL, so they would have to put the embed code in some other asset type to get the behavior Bill is describing. Give me copy that will show up in the help drawer explaining that users just have to copy and paste the URL and the video will automatically be embedded and I'll wire it in.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jwirfs-brock"><img src="https://avatars.githubusercontent.com/u/1020518?v=4" />jwirfs-brock</a> commented <strong> 12 years ago</strong> </div> <div class="markdown-body"> <p>Here is some instructional copy:</p> <p><strong>Embed a video from YouTube or Vimeo.</strong> Find the video on YouTube or Vimeo, copy the URL from your browser, and paste it below. </p> <p>Make sure you use the link and <strong>not</strong> the embed code, which looks something like this: <code><iframe src="http://player.vimeo.com/video/43671182" width="500" height="281" frameborder="0"></iframe></code></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
If a user tries to grab the