search

denverfoundation / storybase

The code behind Floodlight
http://floodlightproject.org
MIT License
11 stars 7 forks source link

"Floating" filters on top of Explore page #937

Closed jwirfs-brock closed 10 years ago

jwirfs-brock commented 10 years ago

On the explore page, I'm a bit ambivalent about the sticky filters that appear to float above the rest of the page when you scroll down. There's limited real estate already, so giving so much space to the filters seems like it might not be the best idea.

@ghing What are your thoughts?

ghing commented 10 years ago

The stickiness should be triggered based on the filter height as a percentage of the total height. On which device/resolution did you see the filters stick. On Jan 30, 2014 11:50 PM, "Jordan Wirfs-Brock" notifications@github.com wrote:

On the explore page, I'm a bit ambivalent about the sticky filters that appear to float above the rest of the page when you scroll down. There's limited real estate already, so giving so much space to the filters seems like it might not be the best idea.

@ghing https://github.com/ghing What are your thoughts?

Reply to this email directly or view it on GitHubhttps://github.com/PitonFoundation/atlas/issues/937 .

ghing commented 10 years ago

@jwirfs-brock, I'm not seeing the filters stick on my phone, either in landscape or portrait orientation. On what resolutions are you seeing the sticky filters and finding them annoying?

jwirfs-brock commented 10 years ago

I observed this on my Nexus 7 tablet. It's not a huge annoyance, so it that's the only device where it's an issue I say we skip it.

ghing commented 10 years ago

What's the resolution on your tablet, and was it in landscape or portrait mode?

jwirfs-brock commented 10 years ago

I observed it in portrait mode (vertical). Resolution is 1200x800, I believe.

jwirfs-brock commented 10 years ago

Oops, 1280x800. On Feb 3, 2014 3:03 PM, "Jordan Wirfs-Brock" jordanwb@gmail.com wrote:

I observed it in portrait mode (vertical). Resolution is 1200x800, I believe.

ghing commented 10 years ago

In my testing, the filters were only sticky in landscape orientation (1200x800) display and not in portrait (800x1200). The filters didn't really bother me as I could still see one full row of stories.

@jwirfs-brock, if you feel strongly about getting rid of the sticky filters on all displays, or you're seeing them stick on the 800px wide display (portrait mode), please reopen this issue.