search

denysdovhan / bash-handbook

:book: For those who wanna learn Bash
https://git.io/bash-handbook
5.72k stars 757 forks source link

Fix rendering issue with ticks not showing up #12

Closed alebelcor closed 8 years ago

alebelcor commented 8 years ago

I fixed an issue where some ticks were not showing up on rendering. In the process I changed the wording a little bit but I may have misunderstood what you were trying to say.

Please review and let me know. Thank you!

ghost commented 8 years ago

LGTM @denysdovhan

denysdovhan commented 8 years ago

Yep, but it's still broken.

image

At the same time, #2 rendered as it should be rendered. But you have removed in — that's a really mitake. Can you remove space between backquotes in the middle — it should fix the rendering? After that, I'm gonna merge it.

alebelcor commented 8 years ago

That is very interesting, I thought you necessarily needed to put a space in between, as I did, to get the rendering we wanted. However #2 managed to pull it off without having to add that space, or so I thought.

It's quite clever actually, it looks like @andrepolischuk added "no width space" character between the middle backticks and it's making the rendering look like there's no space in there. Which is the look we want.

denysdovhan commented 8 years ago

Now it works:

image

denysdovhan commented 8 years ago

Published as 1.2.1.