search

denysdovhan / inboxer

Unofficial, free and open-source Inbox by Gmail Desktop App
https://denysdovhan.com/inboxer
MIT License
666 stars 74 forks source link

need to add binaries to 1.3.0 release #92

Closed jmarino closed 5 years ago

jmarino commented 5 years ago

@denysdovhan: I just created a new release but I can't generate Windows or Mac binaries on my linux machine. Is there a way to extract them from Travis CI? How do you normally handle releases?

core-code commented 5 years ago

binaries are missing for 1.2.2, 1.3.0 and 1.3.1

laander commented 5 years ago

@denysdovhan Thanks for your effort with this app!

As other's said, binaries doesn't seem to exist for 1.3.0 and 1.3.1. I'm installing it via homebrew and it gives me 1.2.1. Any chance you could generate binaries for the latest version?

eah13 commented 5 years ago

And/or add build instructions. Seems like that'd be good to have for contributions anyways - am I missing them?

jmarino commented 5 years ago

@eah13 that is a really good idea. I added some instructions on how to build packages from source to the README file.

jmarino commented 5 years ago

I finally figured out how to include binaries in releases. I just made releases v1.3.2 and v1.2.3 to force building of binaries.

The binaries are built and automatically uploaded by Travis CI, but only if the release is saved as a draft while the build is ongoing. My mistake was that I was publishing releases too fast, before the Travis CI build was complete. This is what was printed in the Travis CI build log:

• GitHub release not created reason=existing type not compatible with publishing type tag=v1.3.1 version=1.3.1 existingType=release publishingType=draft

Travis CI was telling me all along that I was doing it wrong.

laander commented 5 years ago

@jmarino Awesome, thanks!

Any chance you can publish v1.3.2 to the brew cask too? 😇

core-code commented 5 years ago

if you mark it as 'Latest Release' in GitHub, we'll add it semi-automatically.

jmarino commented 5 years ago

I marked release v1.3.2 as 'Latest Release'. Let me know if the release is successfully added to brew cask.

core-code commented 5 years ago

inboxer v1.3.2 is now in homebrew-cask

laander commented 5 years ago

Awesome, thank you!

On Tue, Apr 2, 2019, 04:55 jmarino notifications@github.com wrote:

Closed #92 https://github.com/denysdovhan/inboxer/issues/92.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/denysdovhan/inboxer/issues/92#event-2245151735, or mute the thread https://github.com/notifications/unsubscribe-auth/AANk02emeYCdKwQ9LsJ6fMXRplwek1zdks5vcsaVgaJpZM4bmzdp .