search

denysdovhan / one-gnome-terminal

Atom's One Dark and One Light theme for GNOME Terminal
MIT License
320 stars 28 forks source link

Fix installation instructions #3

Closed di3goleite closed 7 years ago

di3goleite commented 8 years ago

You must need give permission for this script execute.

denysdovhan commented 8 years ago

I think it seems reasonable.

@kbytin are you maintain this project? What do you think?

maxcnunes commented 8 years ago

Instead of requiring every user to follow these steps I think a solution as the one used by oh-my-zsh is better. There is no need to make the file executable and does not create a temp file. https://github.com/robbyrussell/oh-my-zsh/#basic-installation

Example:

bash -c "$(curl -fsSL https://raw.githubusercontent.com/denysdovhan/gnome-terminal-one/master/one-dark.sh)"
denysdovhan commented 7 years ago

@maxcnunes file shouldn't be just executed, it should be sourced. Could you please open new PR with you proposal and sourcing theme's file?

denysdovhan commented 7 years ago

I close this PR, since @maxcnunes provide a better solution. Would be cool to see a PR with that solution. Gonna merge that one.