Closed gabrymed closed 2 years ago
edenhaus
commented
3 years ago Please open a PR, where you add it and don't comment on a commit, which was merged last year and has completely nothing to do with this issue!
Also this is not a bug, but a feature request. There exists many different vacuum and they have different state, so it can be that only parts are translated. You van add your missing ones by modifing the json file and then submit a PR
gabrymed
commented
3 years ago I'm sorry,my mistake. I'm new on Github,now i know what to do and i won't edit anymore. My apologizes.
Il giorno mer 8 set 2021 alle ore 07:15 Robert Resch < @.***> ha scritto:
Please open a PR, where you add it and don't comment on a commit, which was merged last year and has completely nothing to do with this issue!
Also this is not a bug, but a feature request. There exists many different vacuum and they have different state, so it can be that only parts are translated. You van add your missing ones by modifing the json file and then submit a PR
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/denysdovhan/vacuum-card/issues/234#issuecomment-914924308, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANTWBK2XXVMSVLRPKHIHEF3UA3WQ3ANCNFSM467FS4DQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Gabriele Medici
denysdovhan
commented
2 years ago Open a PR and do it yourself. It's open-source at the end of the day.
Please add translation for "segment_cleaning" state (Roborock S50) . When i use this command the text remain in english at the bottom of the vacuum picture,however the other states are translated. Thanks for your work.