search

denysdovhan / wtfjs

🤪 A list of funny and tricky JavaScript examples
http://bit.ly/wtfjavascript
Do What The F*ck You Want To Public License
34.95k stars 2.55k forks source link

Sinhala translation #130

Closed pavinduLakshan closed 3 years ago

pavinduLakshan commented 4 years ago

referencing #93

pavinduLakshan commented 3 years ago

@denysdovhan, First off, thanks for having a look at my PR, but I have a little thing to clarify.

Also, find someone to check and approve your translation. Thanks!

can you kindly explain what should I exactly do?

denysdovhan commented 3 years ago

@pavinduLakshan find someone who speaks your language to check and approve your translation. I need to make sure your translation is well and readable.

denysdovhan commented 3 years ago

@pavinduLakshan Any update? Did you find someone to review it?

Udith-Gayan commented 3 years ago

@denysdovhan Hi, As per @pavinduLakshan's request, I started reviewing his changes, as a native speaker of Sinhalese. I need some time to review it. Once my review is over, I'll give my comment. Thank you

Udith-Gayan commented 3 years ago

Hi @denysdovhan, I reviewed the file edited by @pavinduLakshan . The translation is in a quite good state and well readable. I didn't even see any typo and I felt that he had done the translation very carefully. Thank you.

denysdovhan commented 3 years ago

Thanks for contributing!

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.20.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: