French translation - Githubissues

denysdovhan / wtfjs

🤪 A list of funny and tricky JavaScript examples

http://bit.ly/wtfjavascript

Do What The F*ck You Want To Public License

34.95k stars 2.55k forks source link

French translation #133

Closed emiliegervais closed 4 years ago

emiliegervais commented 4 years ago

Translation ready!

Notes:

didn't translate the text of links with no French translations: so the user knows before clicking on the link that this content will be in English.
added a link in the README.md for the French translation, but not in the README-zh-cn.md file as the Translations block seems to have been omitted.

emiliegervais commented 4 years ago

Hi, is there any way this will eventually be merged or is this a dead option?

emiliegervais commented 4 years ago

@yoriiis @RobinMoretti

Avez-vous 5-10 min pour faire une review rapidos de ma traduction pour What the f*ck JavaScript stp stp stp ? =)

La version originale : https://github.com/denysdovhan/wtfjs Ma repo pour le pull request est ici : https://github.com/hexangel616/wtfjs/tree/french-translation

Si vous voulez faire des modifs, n'hésitez à forker ma branche et ajouter des commits.

Si vous n'avez pas le temps ou pas envie, I understand (perso, je trouve ça chiant faire de la review de traduction), just let me know!

Merciiiii et bonne journéeeeee =)

yoriiis commented 4 years ago

@hexangel616 Merci pour le merge, la traduction française est ok pour moi ! @denysdovhan Good for me 👍

RobinMoretti commented 4 years ago

Hey je suis en vacance sur une île jusqu’à jeudi, je Check ça vendredi promis, ça m’a l’air super cool comme truc

Envoyé de mon iPad

Le 28 avr. 2020 à 16:31, Emilie Gervais notifications@github.com a écrit :

@yoriiis @RobinMoretti

Avez-vous 5-10 min pour faire une review rapidos de ma traduction pour What the f*ck JavaScript stp stp stp ? =)

La version originale : https://github.com/denysdovhan/wtfjs Ma repo pour le pull request est ici : https://github.com/hexangel616/wtfjs/tree/french-translation

Si vous voulez faire des modifs, n'hésitez à forker ma branche et ajouter des commits.

Si vous n'avez pas le temps ou pas envie, I understand (perso, je trouve ça chiant faire de la review de traduction), just let me know!

Merciiiii et bonne journéeeeee =)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

emiliegervais commented 4 years ago

ça marche @RobinMoretti, merci =) Profite-bien de tes vacances !

denysdovhan commented 4 years ago

@hexangel616 was this reviewed? I see @yoriiis approve. @RobinMoretti do you approve?

emiliegervais commented 4 years ago

@denysdovhan it's been approve by @yoriiis.

@RobinMoretti is in vacation until tomorrow. He mentioned that he would go through it this Friday.

I'll ask someone else if he doesn't.

adriantombu commented 4 years ago

@denysdovhan I've made some small corrections, it should be good to merge once my PR https://github.com/hexangel616/wtfjs/pull/2 is merged on @hexangel616's repo :+1:

emiliegervais commented 4 years ago

@adriantombu merci bcp bcp =))

Hésite pas à me demander si jamais t'as besoin de vérif/review du genre!

emiliegervais commented 4 years ago

@denysdovhan it's been reviewed and approved by @yoriiis & @adriantombu.

denysdovhan commented 4 years ago

Thanks for contributing!

denysdovhan commented 4 years ago

Published as v1.9.0!