search

denzelcjy / pe

0 stars 0 forks source link

Sequence diagram notation issue on page 2 of DG #13

Open denzelcjy opened 1 year ago

denzelcjy commented 1 year ago

For this diagram on the Main Component:

image.png

After the object is deleted as indicated by the red cross in your diagram, why does the lifeline of the object still continue? (bottom left corner)

Also the same issue regarding the classes, should be changed to object with a semicolon (:) before the className

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

errors in the sequential diagram of application overview

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

image.png

the sequential diagram for the main overview doesn't specify where and how the Duke, Data and CommandParser classes are created. They cannot exist before user have done any action.

Similarly, in the second screenshot, CommandParser class shouldn't still exist after user entering exit command.

Moreover, the deletion mark is not correct, there shouldn't be dotted lines after the cross which means the instance is deleted

[original: nus-cs2113-AY2223S2/pe-interim#2448] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Duke, Data and CommandParser are static classes, which you do not need to initialize them. However, the deletion mark that you have mentioned is our mistake.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]