denzilferreira / aware-client

AWARE's Android client. This application allows researchers to easily collect sensor/plugin data locally or remotely to an AWARE server instance.

https://awareframework.com

88 stars 78 forks source link

Screen sensor doesn't record all status changes #282

Closed nleo575 closed 5 years ago

nleo575 commented 5 years ago

During a review of data we have noticed that the sensor isn't accurately recording all changes in screen_status. For example we have noticed two or more consecutive unlocks without a lock or off in between or vice versa. Some of these are due to duplicated entires in the screen table, others though have different timestamps and are indeed errors.

The error also seems to be present on iOS.

denzilferreira commented 5 years ago

I'm now using also PowerManager.isInteractive() and KeyguardManager.isKeyguardLocked() to tell where the screen is actually on or off, unlocked and locked as some devices don't send some of the broadcasts at all. I made the sensor into a state machine design pattern, should be fixed now.

Can you confirm on your device? It seems to be OK in OnePlus 6T running Android 9.

nleo575 commented 5 years ago

Our test was using build AWARE build 256 from Jenkins. In what version of the client did you implement this fix?

denzilferreira commented 5 years ago

Forgot to set Jenkins to build. Building, this would be build 262.

Denzil;

On Thu, Oct 31, 2019, 16:41 Nicolas Leo notifications@github.com wrote:

Our test was using build AWARE build 256 from Jenkins. In what version of the client did you implement this fix?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/denzilferreira/aware-client/issues/282?email_source=notifications&email_token=AB7U2LK57ALC65OYXFDI7STQRLVCZA5CNFSM4JG737Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECYAYPQ#issuecomment-548408382, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7U2LLZZX7B7IJTFA6WOHDQRLVCZANCNFSM4JG737QQ .