Closed supun-io closed 5 months ago
Hey @supun-io, Thanks for contributing.
It looks like it is supposed to do what you intend. If there are any improvements, you can always make a new PR.
If you call the analyze.output(&mut results, format.clone(), args.summary_only);
after the for
. You will get the same output; if not, I think it's then something that will need to change in the analyze
module.
But for now, I will be merging it. :D
I'm unsure, but printing to the stdout has some overhead. But I will do my research to find out for sure.
To scan files, a new argument is probably needed (--file / --files?)
This will be really useful, for what I'm currently building. I'm making a site for Phanalist where you can test a snippet of code. Just like Phpstan and the rest.
Hey!
It looks like setting --src
to a filename works.
phanalist --src=./target/test.php --src=./target/test2.php
I guess WalkDir
accepts filenames as well. So, just keeping --src for now would work.
I'm making a site for Phanalist where you can test a snippet of code.
Exiciting!
I was playing with the source code and made a few changes to make scanning multiple directories possible #12
Instead of adding a new command line argument, I made
src
avec
so that using multiple srcs is valid:It's not a perfect solution though.
(I'm happy to work on improvements if the concept looks good)
Some other ideas I had:
--file
/--files
?)