deoplete-plugins / deoplete-jedi

deoplete.nvim source for Python
MIT License
589 stars 39 forks source link

Latest version of jedi crash on Windows #261

Closed jdhao closed 4 years ago

jdhao commented 4 years ago

Problem summary

Latest version (0.17.0) or master branch of Jedi will crash on Windows, as reported here. Since deoplete-jedi depends on Jedi, I think it should be reported here too.

Older versions Jedi works well. I wonder if there is way to specify Jedi version to use for deoplete-jedi?

Shougo commented 4 years ago

Unfortunately you cannot specify the version. deoplete-jedi includes jedi. If it is fixed in upstream, I will include the changes.

jdhao commented 4 years ago

Maybe jedi should be decoupled from deoplete-jedi so that users can upgrade or downgrade Jedi more freely, as discussed here.

Currently, I have to go to the directory where jedi is embedded in deoplete-jedi (On my system, the directory is: C:\Users\Administrator\AppData\Local\nvim-data\plugged\deoplete-jedi\rplugin\python3\deoplete\vendored\jedi) and checkout the old commit like this:

git checkout tags/v0.16.0

It is a bit cumbersome as compared to pip install -U jedi==0.16.0.

Shougo commented 4 years ago

Yes. But users needs to install/upgrade jedi module manually. It is really desired behavior? I need more users voice.

jdhao commented 4 years ago

@Shougo As long as you state explicitly on the repo home page which versions of Jedi are required for deoplete-jedi to work properly, I think it is the user's responsibility to meet that requirement. The plugin shouldn't do that for the user unless explicitly instructed by the user.

For example, deoplete requires certain Python versions to run, but it shouldn't install Python for the user. It is the user who need to fulfill that requirement.

Shougo commented 4 years ago

@jdhao Please test https://github.com/deoplete-plugins/deoplete-jedi/pull/262.

jdhao commented 4 years ago

@Shougo It works. I can use jedi 0.16 with deoplete-jedi without any error.

Shougo commented 4 years ago

I will merge it later.

Shougo commented 4 years ago

I have merged it.