depado / goploader

Easy file sharing with server-side encryption, curl/httpie/wget compliant
https://docs.gpldr.in
MIT License
273 stars 41 forks source link

change temporarily folder? #31

Closed bioryb closed 6 years ago

bioryb commented 8 years ago

Hi, I am just testing goploader. Now, I will use it for uploading big files (~20GB-50GB).

On my first test I figured out, that the files are temporarily stored in /tmp (using Debian 8). Is there a way to change this to another directory?

Thanks in advance and really thank you for this piece of software!!

Ronny

depado commented 8 years ago

Are you talking about the client or the server side ?

On the server side I will have to investigate because I don't remember (and a quick search confirmed that) using the /tmp path anywhere in the code.

bioryb commented 8 years ago

I am talking about the server side. But maybe a flag to configure would be fine for the client, too. The problem is, that I have a lot of space for the file storage, but not for /tmp :-/

Would be great if there could be a flag to configure where to place temp files.

depado commented 8 years ago

I'll investigate on that. I don't remember using /tmp at all on the server side, so I guess that comes from the encryption lib or something like that.

bioryb commented 8 years ago

Hi, just checked if this has gone if encryption is disabled - no.

Just for your information

depado commented 8 years ago

Mind if I ask if you have a webserver in front of Goploader ? (I'm using Caddy)

bioryb commented 8 years ago

Actually for testing I do not use a webserver in front of goploader.

However, this may not have any impact on this issue?!?!

depado commented 8 years ago

Just checking. This may not impact this issue indeed.

bioryb commented 8 years ago

Hi, did you find anything on this issue? Actually, this is the only show stopper for me.

This morning I did a strace to find any hint on this, but I did not get anything.

depado commented 8 years ago

Hi, Currently I have little time to work on goploader, so no, not yet. I'm sorry this stops you :/

Also I can't seem to reproduce the issue. When I upload a 30MB file, there is no file creation in /tmp, only in my upload folder configured in my conf.yml file. I'll give it a try with a very large limit/file. Do you recon this happens during the encryption process or as soon as the file is being sent ?

EDIT: Nevermind, as soon as the file is bigger than 50MB, a temporary file is generated in /tmp, now I just have to find why and how to solve that.

depado commented 8 years ago

This is just for me as a reminder :

So !

SOLUTION : Set the environment variable TMPDIR to the absolute path of your upload_dir configuration variable and you're good to go. I guess. I'll try that later.

I'll probably provide a fix though, setting up the environment variable directly from the program so this kind of issue don't happen again.

bioryb commented 8 years ago

That works!

Great! Thank YOU!