department-for-transport-BODS / bods-data-extractor

A python client for downloading and extracting data from the UK Bus Open Data Service
Other
44 stars 8 forks source link

Bug with 'ATCO_code_to_LA_lookup.csv' file mapping to null ATCO codes and admin area's #26

Closed isrirai1 closed 1 year ago

isrirai1 commented 1 year ago

Describe the bug Where there are null values in the 'ATCO_code_to_LA_lookup.csv', these are being mapped incorrectly to a service. This is resulting in confusion when determining whether a service is in BODS or not.

To Reproduce Steps to reproduce the behavior:

  1. Method 'services_on_bods_or_otc_by_area()' is for some services showing incorrect admin areas.

Expected behavior Auth descriptions/ATCO codes should correctly match to the 'ATCO_code_to_LA_lookup.csv'. To deal with issue, rows with null values have been removed from the 'ATCO_code_to_LA_lookup.csv' file.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

lldwork commented 1 year ago

not sure this fix is sustainable - does LA to ATCO never change?

spencer-b-318 commented 1 year ago

Note for future table - raise an error if blank ATCO code found

adamakram1 commented 1 year ago

Create an additional ticket