Incorrect Parsing of timetables (6)

[spencer-b-318]

Describe the bug Some vehicle journeys appear to be overlapping with duplicate sequence numbers at different stops/times. Could be due to inbound / outbound journeys being displayed on the same column

Expected behaviour Timetables should be split by inbound/outbound and take into account days of operation. Vehicle Journeys and Journey patters are relevant to timetable calculation and should both be displayed in final output to aid analysis and troubleshooting.

Additional context Additional Features to current Iteration

• [ ] Split Outbound and Inbound Journey Patterns
• [ ] Show Route ID
• [ ] Show Journey Pattern Days of Operation (Mon-Sat / Sat-Sun)
• [ ] Stops should be in stop order, sequences can be referenced next to time (see example)
• [ ] Principal Timing Points marked

[spencer-b-318]

Example Timetable

Outbound

Journey Pattern ID	JP_9	JP_10
Vehicle Journey	vj_1	vj_2
Route ID	Rt_1	Rt_2
Days	Mon - Fri	Sun
Bus Station	…	09:00
Hospital	…	09:05
Market	08:10	09:10
University	08:15	09:15

Inbound

Journey Pattern ID	JP_9	JP_10
Vehicle Journey	vj_1	vj_2
Route ID	Rt_1	Rt_2
Days	Mon - Fri	Sun
University	…	08:00
Market	…	08:05
Hospital	07:10	08:10
Bus Station	07:15	08:15

[spencer-b-318]

@adamakram1

Extract JSON data from the XML

• [ ] Functionality exists in package

Define python dataclasses to hold the data from the JSON elements

• [x] VehicleJourney and associated sub-elements

• [x] JourneyPatternSection and associated sub-elements

• [x] Service element and asociated child elements

• [x] Begin to populate dataclass objects with relevant data from example files

• [ ] Use the PTI to link the objects and convert to dataframe as shaped above

I suggest working in this order:

• [x] Build these functions on a local XML file, completely outside of the package
• [ ] Integrate into package

[spencer-b-318]

https://jsonformatter.org/xml-viewer

[adamakram1]

Describe the bug Currently, due to specific PTI logic that is not accounted for, vehicle journeys that overlap midnight (ie start at 23:50 and end at 01:00), are incorrectly represented in the final timetables output.

To Reproduce Steps to reproduce the behavior: Run the below code then find a vehicle journey that overlaps 00:00

#intiate an object instance called my_bus_data_object with desired parameters
from BODSDataExtractor.extractor import TimetableExtractor

my_bus_data_object = TimetableExtractor(api_key=api # Your API Key Here
                                 ,limit=1 # How many datasets to view
                                 ,status = 'published' # Only view published datasets
                                 ,service_line_level=True # True if you require Service line data 
                                 ,stop_level=True # True if you require stop level data
                                 )

#save the extracted stop level data to stop_level variable
stop_level = my_bus_data_object.timetable_dict

#note that in downloading stop level the  data, the dataset and service line level will also be downloaded. Can access this as below:
dataset_level = my_bus_data_object.metadata
service_line_level = my_bus_data_object.service_line_extract

#save meta data and service line level data to csv file in your downloads directory
my_bus_data_object.save_metadata_to_csv()
my_bus_data_object.save_service_line_extract_to_csv()

#stop_level variable is a dictionary of dataframes, which can be saved to csv as follows (saves in downloads directory)
my_bus_data_object.save_all_timetables_to_csv()

Expected behavior These vehicle journeys that overlap midnight should be represented accurately.

Additional context This bug needs investigating more thoroughly before it can be fixed. Suggest reading PTI 1.1 doc on midnight timetables first.

[adamakram1]

Create an additional Ticket for the next sprint with fewer story points Inform simplifyai- Take an extra sprint to get it into a better place