v3.2.3 Schema and examples inconsistency

[janicki95]

Lack of consistency between the v3.2.3 schema and examples given.

JSON schema expects the source->section property to be a string[] (array of string values). All examples provided show this property as a string value only. How do you want this property provided?

Example:

Schema:

[ruipinge]

Also detected a few:

• regulation.contition.regulationStatus: exists in the examples but no longer in the schema
• RegulationType enum: miscSuspensionOfBusway type doesn't exist in the schema
  • see https://github.com/department-for-transport-public/D-TRO/issues/2#issuecomment-2326826023
• UniqueStreetReferenceNumber.items.$ref: #/defs/UniqueStreetReferenceNumber -> #/$defs/UniqueStreetReferenceNumber
• emissionClassificationEuro.items.$ref: #/$defs/emissionClassificationEuroType -> #/$defs/EmissionClassificationEuroType
• UniqueStreetReferenceNumber.items.$ref: #/$refs/UniqueStreetReferenceNumber -> #/$defs/UniqueStreetReferenceNumber
• Source.properties: Provision -> provision
• Privision.properties: RegulatedPlace -> regulatedPlace
• Privision.properties: Regulation -> regulation
• RegulatedPlace.properties: Geometry -> geometry
• Structure between ExternalReference and DirectedLinear/LinearGeometry/PointGeometry/Polygon doesn't match between:
  • Examples: LinearGeometry is "sibling" of ExternalReference
  • JSON Schema: LinearGeometry is "child" of ExternalReference
• geometry property type doesn't match:
  • Examples: geometry is an object
  • JSON Schema: geometry is an array

[stm-john-cooper]

Thanks for raising this issue. We are reviewing and will update/fix as soon as possible.

[ajf2]

In JSON-3.2.3-example-point-dtro.json, externalReference should now be a singular object, and its UniqueStreetReferenceNumber property should be an array. I'd argue that all properties should begin with a lowercase letter or at least be consistent, ~but that doesn't really matter.~

It seems the validation on the server is case sensitive and expects to find a Source or Consultation property starting with a capital letter, so consistency would be appreciated!

[JHB9876]

On behalf of DfT:

Many thanks for raising these issues. The DfT D-TRO team have been reviewing and expect to imminently issue a data specification release (v3.2.4) which aims to address the issues raised.

[JHB9876]

On behalf of DfT:

Again, many thanks for raising these issues. Many of the issues raised have been addressed in the data specification release 3.2.4. In a small number of cases, the correction requires a code base change to the D-TRO Service and we have recorded the issue and resolution and will address in a future release of the data specification.