By submitting this PR I confirm I have read and understood the Github Standards document and understand the role I play in ensuring standards, security, and assurance at DfT.
As a PR reviewer
By accepting this PR I understand my responsibilities as described in the the Github standards document.
Proposed changes
Split bq_tableizer() function into package, and added unit tests
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply
[ ] Bugfix (change which fixes an issue)
[X] New feature (change which adds functionality)
[ ] Documentation Update (change to naming or other documentation)
Points I have checked in my code
Put an x in the boxes that apply. You can also fill these out after creating the PR.
[X] I have added unit tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)
[ ] I have checked that my changes have not broken any other functionality
[ ] I have linked to any issues this PR fixes
Points for review
Add checkboxes here for any specific aspects of your PR you would like to be checked in peer review. If you don't specify anything here, the reviewer will check:
[X] All of your unit tests pass
[X] Your code is clear and easy to understand
[ ] You have documented any new features
[ ] They can run the code you have written
[X] Your changes do not break any other functionality
Security considerations
Put an x in the boxes that apply. You should have considered all of these points before submitting a PR.
[X] My code does not contain any secrets such as passwords, API keys, etc
[X] I have not accidentally uploaded any data to Github
[X] My code does not include any personal information such as names or email addresses
As a contributor
By submitting this PR I confirm I have read and understood the Github Standards document and understand the role I play in ensuring standards, security, and assurance at DfT.
As a PR reviewer
By accepting this PR I understand my responsibilities as described in the the Github standards document.
Proposed changes
Split bq_tableizer() function into package, and added unit tests
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyPoints I have checked in my code
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Points for review
Add checkboxes here for any specific aspects of your PR you would like to be checked in peer review. If you don't specify anything here, the reviewer will check:
Security considerations
Put an
xin the boxes that apply. You should have considered all of these points before submitting a PR.Who is reviewing this PR?
@Mo-Dell