department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
18 stars 6 forks source link

EP Merge: Fix issue with get pending contentions 204 #3045

Closed dfitchett closed 2 months ago

dfitchett commented 2 months ago

What was the problem?

A bug has been observed in production which occurs when the pending claim returned a 204 on getting the contentions. This 204 resulted in the merge job failing due to 204 not being an acceptable status of that request, even tho the contentions from the EP400 could have been moved over successfully.

Associated tickets or Slack threads:

How does this fix it?[^1]

Allows 204s on the request to get contentions for the pending claim.

How to test this PR

[^1]: Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. [^secrel]: To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

github-actions[bot] commented 2 months ago

Test Results

109 tests  ±0   109 :white_check_mark: ±0   35s :stopwatch: +2s  33 suites ±0     0 :zzz: ±0   33 files   ±0     0 :x: ±0 

Results for commit 3277e85e. ± Comparison against base commit e4a06e13.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

JaCoCo Test Coverage

Overall Project 65.29% :x:

There is no coverage information present for the Files changed