Closed dfitchett closed 2 months ago
109 tests ±0 109 :white_check_mark: ±0 34s :stopwatch: ±0s 33 suites ±0 0 :zzz: ±0 33 files ±0 0 :x: ±0
Results for commit 99e60378. ± Comparison against base commit bbb7d01e.
:recycle: This comment has been updated with latest results.
Overall Project | 65.29% | :x: |
---|
There is no coverage information present for the Files changed
This looks good to go; I have no blocking concerns.
One question, maybe a slight worry: wouldn't it be easier, long-term, to collapse updates into the one CSV that gets loaded? Not that Python can't load up gobs and gobs of CSVs at startup-time, but it might get unwieldy for a human to figure out what file is responsible for a particular DC's maximum.
Yeah, that's a good point. My original thought was that it would be easier to add updates to the app if all you had to do was drop in the file, but that does make it somewhat harder to find where any diagnostic code's max rating comes from. Maybe I'll pull that functionality out of the app and into a script that combines the files into one.
What was the problem?
EE was provided an updated eCFR for digestive systems, and the maximum ratings API needs updating.
Associated tickets or Slack threads:
3047
How does this fix it?[^1]
Adds another lookup table that adds/updates diagnostic codes with their associated maximum ratings. In future updates, only the file will need to be added to make eCFR updates.
How to test this PR
Run the checks (unit tests, isort, ruff, etc.,):
./gradlew check