department-of-veterans-affairs / abd-vro

To get Veterans benefits in minutes, VRO software uses health evidence data to help fast track disability claims.
Other
18 stars 6 forks source link

removed json log #3055

Closed chengjie8 closed 2 months ago

chengjie8 commented 2 months ago

What was the problem?

Apache Camel logs the JSON message body before it converts to the Java BieMessagePayload class. This process ignores some restrictions we introduced in the Java class via annotations, causing some fields that we do not want to show in the logs to be printed out as well.

Associated tickets or Slack threads:

How does this fix it?[^1]

Removed logging of the JSON string; only log once the JSON string is converted into our Java class.

How to test this PR

[^1]: Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. [^secrel]: To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

github-actions[bot] commented 2 months ago

JaCoCo Test Coverage

Overall Project 65.88% :x:
File Coverage
BieXampleRoutes.java 100% :green_apple: